MAINT: Replace defusedxml with mffpy in _get_ep_info and _get_signalfname (mne-tools#13991)

Author: PragnyaKhandelwal

doc/changes/dev/13991.other.rst

@@ -0,0 +1 @@
+Replace ``defusedxml``-backed implementations of ``_get_ep_info`` and ``_get_signalfname`` in the EGI MFF reader with ``mffpy``-backed parsing via :func:`mne.io.read_raw_egi`, by `Pragnya Khandelwal`_.

mne/io/egi/general.py

@@ -52,23 +52,16 @@ def _get_gains(filepath):
 
 def _get_ep_info(filepath):
     """Get epoch info."""
-    _soft_import("defusedxml", "reading EGI MFF data")
-    from defusedxml.minidom import parse
+    from mffpy.xml_files import XML
 
-    epochfile = filepath + "/epochs.xml"
-    epochlist = parse(epochfile)
-    epochs = epochlist.getElementsByTagName("epoch")
+    ep_obj = XML.from_file(os.path.join(filepath, "epochs.xml"))
     keys = ("first_samps", "last_samps", "first_blocks", "last_blocks")
     epoch_info = {key: list() for key in keys}
-    for epoch in epochs:
-        ep_begin = int(epoch.getElementsByTagName("beginTime")[0].firstChild.data)
-        ep_end = int(epoch.getElementsByTagName("endTime")[0].firstChild.data)
-        first_block = int(epoch.getElementsByTagName("firstBlock")[0].firstChild.data)
-        last_block = int(epoch.getElementsByTagName("lastBlock")[0].firstChild.data)
-        epoch_info["first_samps"].append(ep_begin)
-        epoch_info["last_samps"].append(ep_end)
-        epoch_info["first_blocks"].append(first_block)
-        epoch_info["last_blocks"].append(last_block)
+    for ep in ep_obj.epochs:
+        epoch_info["first_samps"].append(ep.beginTime)
+        epoch_info["last_samps"].append(ep.endTime)
+        epoch_info["first_blocks"].append(ep.firstBlock)
+        epoch_info["last_blocks"].append(ep.lastBlock)
     # Don't turn into ndarray here, keep native int because it can deal with
     # huge numbers (could use np.uint64 but it's more work)
     return epoch_info
@@ -132,8 +125,7 @@ def _get_blocks(filepath):
 
 def _get_signalfname(filepath):
     """Get filenames."""
-    _soft_import("defusedxml", "reading EGI MFF data")
-    from defusedxml.minidom import parse
+    from mffpy.xml_files import XML
 
     listfiles = os.listdir(filepath)
     binfiles = list(
@@ -145,16 +137,14 @@ def _get_signalfname(filepath):
         bin_num_str = re.search(r"\d+", binfile).group()
         infofile = "info" + bin_num_str + ".xml"
         infofiles.append(infofile)
-        infobjfile = os.path.join(filepath, infofile)
-        infobj = parse(infobjfile)
-        if len(infobj.getElementsByTagName("EEG")):
-            signal_type = "EEG"
-        elif len(infobj.getElementsByTagName("PNSData")):
-            signal_type = "PNS"
-        all_files[signal_type] = {
-            "signal": f"signal{bin_num_str}.bin",
-            "info": infofile,
-        }
+        info_obj = XML.from_file(os.path.join(filepath, infofile))
+        channel_type = (
+            info_obj.get_content().get("generalInformation", {}).get("channel_type", "")
+        )
+        if channel_type == "EEG":
+            all_files["EEG"] = {"signal": f"signal{bin_num_str}.bin", "info": infofile}
+        elif channel_type == "PNSData":
+            all_files["PNS"] = {"signal": f"signal{bin_num_str}.bin", "info": infofile}
     if "EEG" not in all_files:
         infofiles_str = "\n".join(infofiles)
         raise FileNotFoundError(