Skip to content

Commit 107d503

Browse files
Fixed noise on start/stop (#91)
1 parent bef3bee commit 107d503

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

src/ESP32_VS1053_Stream.cpp

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -326,10 +326,12 @@ bool ESP32_VS1053_Stream::connectToHost(const char *url, const char *username,
326326
_vs1053->stopSong();
327327
snprintf(_url, sizeof(_url), "%s", url);
328328
_vs1053->startSong();
329+
329330
}
330331
_streamStallStartMS = 0;
331332
log_d("redirected %i times to %s", _redirectCount, url);
332333
_redirectCount = 0;
334+
_vs1053->setVolume(_volume);
333335
return true;
334336
}
335337

@@ -457,7 +459,6 @@ void ESP32_VS1053_Stream::_handleStream(WiFiClient *stream)
457459
if (!_dataSeen)
458460
{
459461
_dataSeen = true;
460-
_vs1053->startSong();
461462
_bitrateTimer = millis();
462463
}
463464

@@ -545,7 +546,6 @@ void ESP32_VS1053_Stream::_handleChunkedStream(WiFiClient *stream)
545546
if (!_dataSeen)
546547
{
547548
_dataSeen = true;
548-
_vs1053->startSong();
549549
_bitrateTimer = millis();
550550
}
551551
}
@@ -704,16 +704,14 @@ void ESP32_VS1053_Stream::stopSong()
704704
if (!_http && !_playingFile)
705705
return;
706706

707+
_vs1053->setVolume(0);
707708
_remainingBytes = 0;
708709
_offset = 0;
709710
_bitrate = 0;
710711
_bitrateTimer = 0;
711712
_codec = CODEC_UNKNOWN;
712713
_decoderSyncAttempts = 0;
713714

714-
while (!_vs1053->data_request())
715-
yield();
716-
717715
if (_ringbuffer_handle)
718716
{
719717
size_t size;
@@ -817,6 +815,7 @@ bool ESP32_VS1053_Stream::connectToFile(fs::FS &fs, const char *filename, const
817815
_bufferIndex = 0;
818816
_bufferFill = 0;
819817
_bitrateTimer = millis();
818+
_vs1053->setVolume(_volume);
820819

821820
return true;
822821
}

0 commit comments

Comments
 (0)