Use strchr instead of counting spaces in a loop (#105)

Author: CelliesProjects

src/ESP32_VS1053_Stream.cpp

@@ -275,30 +275,22 @@ bool ESP32_VS1053_Stream::connectToHost(const char *url, const char *username,
         return false;
     }
 
-    bool needsEscape = false;
-    for (size_t i = 0; i < length; ++i)
+    _http = new HTTPClient;
+    if (!_http)
     {
-        if (url[i] == ' ')
-        {
-            needsEscape = true;
-            break;
-        }
+        log_e("Could not create http client");
+        return false;
     }
 
+    const bool needsEscape = (strchr(url, ' ') != nullptr);
+
     if (needsEscape && !_escapeUrl(url, length))
     {
         log_e("Escaped URL exceeds buffer");
         return false;
     }
 
-    _http = new HTTPClient;
-    if (!_http)
-    {
-        log_e("Could not create http client");
-        return false;
-    }
-
-    bool isHttps = (length > 4 && tolower(url[4]) == 's');
+    const bool isHttps = (length > 4 && tolower(url[4]) == 's');
 
     _http->setConnectTimeout(isHttps ? VS1053_CONNECT_TIMEOUT_MS_SSL
                                      : VS1053_CONNECT_TIMEOUT_MS);