Conversation
Co-authored-by: cubap <1119165+cubap@users.noreply.github.com>
Contributor
Copilot
AI
changed the title
[WIP] Fix incorrect error message for invalid HTML tags in QuickType
Fix QuickType validation error messages, duplicate toasts, and panel overflow
Dec 18, 2025
cubap
approved these changes
Dec 18, 2025
Changed the quicktype interface edit URL from '/interfaces/quicktype' to '/manage/quicktype' to reflect updated routing.
cubap
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three QuickType interaction issues identified during manual testing: misleading validation errors for malformed HTML tags, duplicate success toasts on save, and hidden shortcuts when panel content exceeds max height.
Changes
Validation error clarity: Changed error message from "HTML must include a full opening and closing tag or be self-closing" to "Invalid HTML tag. Tag names must start with a letter and contain only letters, numbers, underscores, or hyphens." Prevents confusion when entering tags like
<bry@n></bry@n>where the tag name itself is invalid.Invalid entry handling: Reordered validation logic to check duplicates before validation, then reject invalid entries with error status instead of adding them with warning status. Previously
<bry@n></bry@n>would be added to the list despite being invalid.Duplicate toast elimination: Removed redundant
saveShortcuts()call in manager's event handler. Dialog already saves and shows success toast; manager now only updates local state onquicktype-editor-savedevent.Panel scrolling: Added
overflow-y: autoto.char-panel.showCSS. With hundreds of shortcuts wrapping beyond 500px max-height, content is now scrollable rather than clipped.Files Modified
components/quicktype/validation.js- error messagecomponents/quicktype-tool/quicktype-editor-dialog.js- validation flowcomponents/quicktype-manager/index.js- event handlercomponents/quicktype-tool/index.js- panel CSSOriginal prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.