Skip to content

Small Fixes For Permissions#463

Merged
cubap merged 2 commits intomainfrom
2-12-permissions-improvements
Feb 12, 2026
Merged

Small Fixes For Permissions#463
cubap merged 2 commits intomainfrom
2-12-permissions-improvements

Conversation

@thehabes
Copy link
Copy Markdown
Member

@thehabes thehabes commented Feb 12, 2026

  • Fix metadata page permission checks — The inline script in metadata.html passed '*' as the entity to checkEditAccess, checkDeleteAccess, and checkCreateAccess. In permissionMatch, * on the requested side is a literal string, not a wildcard (only ANY is a wildcard there). This caused users with *_METADATA_PROJECT to be incorrectly denied. Changed entity to 'PROJECT' so the built permission strings (UPDATE_METADATA_PROJECT, etc.) correctly match.
  • Fix project-permissions authgate — The <tpen-project-permissions> component only checked PERMISSION view access, but it also needs ROLE view access to list permissions by role. Added the missing checkViewAccess('ROLE', '*') requirement.
  • Minor cleanup — Renamed checkCreateAccess variable to hasCreateAccess to match the has*Access naming convention of the sibling variables.

Closes #200
Closes #190

@thehabes thehabes self-assigned this Feb 12, 2026
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Feb 12, 2026

@thehabes thehabes marked this pull request as ready for review February 12, 2026 18:58
@thehabes thehabes requested a review from cubap February 12, 2026 19:00
@cubap cubap merged commit 047d778 into main Feb 12, 2026
2 checks passed
@cubap cubap deleted the 2-12-permissions-improvements branch February 12, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update Project Metadata Permissions Project Permissions Permissions

2 participants