Skip to content

Small Fixes For Permissions #463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cubap merged 2 commits into from
Feb 12, 2026
Merged

Small Fixes For Permissions #463

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c0e6d0b
small fixes to permissions
thehabes Feb 12, 2026
eb638fd
small fixes to permissions
thehabes Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions components/project-permissions/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,10 @@ class ProjectPermissions extends HTMLElement {

/**
* Authorization gate - checks permissions before rendering.
* Shows permission message if user lacks PERMISSION view access.
* Shows permission message if user lacks PERMISSION and ROLE view access.
*/
authgate() {
if (!CheckPermissions.checkViewAccess('PERMISSION', '*')) {
if (!(CheckPermissions.checkViewAccess('PERMISSION', '*') && CheckPermissions.checkViewAccess('ROLE', '*'))) {
this.shadowRoot.innerHTML = `<p>You don't have permission to view project permissions</p>`
return
}
Expand Down
8 changes: 4 additions & 4 deletions interfaces/project/metadata.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,9 @@ <h3>Edit Project Metadata</h3>
if (!scope) {
return
}
const hasEditAccess = CheckPermissions.checkEditAccess('*', scope.toUpperCase())
const hasDeleteAccess = CheckPermissions.checkDeleteAccess('*', scope.toUpperCase())
const checkCreateAccess = CheckPermissions.checkCreateAccess('*', scope.toUpperCase())
const hasEditAccess = CheckPermissions.checkEditAccess('PROJECT', scope.toUpperCase())
const hasDeleteAccess = CheckPermissions.checkDeleteAccess('PROJECT', scope.toUpperCase())
const hasCreateAccess = CheckPermissions.checkCreateAccess('PROJECT', scope.toUpperCase())

if (hasEditAccess) {
divMetadata.style.display = 'inline-block'
Expand All @@ -120,7 +120,7 @@ <h3>Edit Project Metadata</h3>

const addButton = document.querySelector('#add-field-btn')
if (addButton) {
if (checkCreateAccess) {
if (hasCreateAccess) {
addButton.style.display = 'inline-block'
} else {
addButton.remove()
Expand Down