Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #462
Encountered #467
Summary
Eliminates 12 instances of
href="#"across the codebase to prevent the#character from polluting the browser URL and history. If a href is ever set it is a<a>. If a href is never set, it is a<button>.Approach
manage-project,project): Removedhref="#", addedtabindex="0"for keyboard accessibility. JS sets realhrefafter project loads.<a href="#">to<button>with CSS resets to match existing styling.list-navigation): Converted non-interactive<a href="#">Loading...</a>to<span>.focus-visiblestyles to Card component slotted<a>and<button>elements for keyboard navigation visibility.Files Changed
interfaces/manage-project/index.html— 6 card footer linksinterfaces/project/index.html— leave project linkcomponents/gui/site/Header.js+header.css— logout buttoncomponents/new-action.js— TPEN 2.8 import buttoncomponents/project-details/index.js— edit title buttoncomponents/projects/list-navigation.js— loading placeholderinterfaces/import-tpen28/index.html— open project buttoncomponents/gui/card/Card.js— focus-visible stylesTesting
href="#"remains in codebaseNote
Now buttons look a little different here..

This occurs in other places where we made such changes, like in /annotator and /manage-columns.
This will help set the stage for #465 where we would have to look at all of those and think about it.