Conversation
Handle immediate dialog teardown and interaction blocking: register a 'tools-dismiss' listener to call closeNow, call closeNow during disconnectedCallback, and add a closeNow() method that clears any close timeout, removes 'show' classes from overlay/container, and invokes overlay.close(). Also update CSS to disable pointer events by default and enable them only when .show is present so the hidden overlay doesn't intercept clicks.
Contributor
Member
Author
|
Implementation details
Verification
Open transcription with multipage project
Scope and safety
|
thehabes
approved these changes
Mar 10, 2026
Member
thehabes
left a comment
thehabes
left a comment
There was a problem hiding this comment.
I confirm that main still has the bug, and that this branch fixes it. No issues found during static review and manual testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a click interception path where the quicktype dialog overlay could remain interactive beyond intended visibility. The patch adds explicit force-close lifecycle cleanup and tightens pointer-events so the overlay only accepts pointer input while visually shown.
Closes #500