Merged
Conversation
Add a private #validateResponse method to parse JSON/text responses, extract meaningful error messages, and detect semantic failures even when HTTP status is 200. Replace ad-hoc response.ok checks across member/role API calls (removeMember, promoteUser, removeLeaderRole, revokeWriteAccess, setUserRoles, updateRoles) to use #validateResponse, return the parsed payload when available, surface user-friendly messages via userMessage/alerts, and rethrow errors so callers can handle them. This change prevents silent success on semantically failed responses and centralizes response validation/decoding.
Contributor
…rface is having all kinds of trouble
thehabes
approved these changes
Mar 16, 2026
Member
thehabes
left a comment
thehabes
left a comment
There was a problem hiding this comment.
I am having all kind of UX issues with this interface, both upstream and in here. I think this PR can go through, but we need to do usability testing on this interface and have another pass at it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added a test as well.