407 do over (#458)

* caller choses whether to save after

* Add shouldUpdate flag to Group role methods

Introduce an optional shouldUpdate parameter to Group.setMemberRoles and Group.removeMemberRoles to control whether changes are immediately persisted. These methods now skip calling update() when shouldUpdate is false, allowing callers to batch multiple role mutations and perform a single update. Call sites updated: removed a redundant update in Project.removeMember flow and adjusted memberRouter to pass shouldUpdate=false for intermediate role changes, then call group.update() once after all changes. This reduces redundant DB writes and improves efficiency.

* auditfix

* whitespace

* No updated packages yet

---------

Co-authored-by: Bryan Haberberger <bryan.j.haberberger@slu.edu>

Author: cubap

classes/Group/Group.js

@@ -191,8 +191,8 @@ export default class Group {
         const member = this.data.members[memberId]
         if (!member) {
             throw {
-              status: 400,
-              message: "User is not a member of this group"
+                status: 400,
+                message: "User is not a member of this group"
             }
         }
         const userRoles = member.roles
@@ -324,8 +324,8 @@ export default class Group {
             await this.addMemberRoles(this.data.creator, "OWNER", true, false)
         }
         if (!this.getByRole("LEADER")?.length) {
-                        await this.addMemberRoles(this.data.creator, "LEADER", false, false)
-                }
+            await this.addMemberRoles(this.data.creator, "LEADER", false, false)
+        }
     }
 
     static async createNewGroup(creator, payload) {