Fix PUT /page/:pageid Column Generation Behavior#503
Merged
cubap merged 1 commit intodevelopmentfrom May 1, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #502.
PUT
/page/:pageIdwas creating one new column per new line item. This was observed when the "Detect Lines" prompts submit all lines in a single PUT, which produced N single-line columns whose order had no relationship to reading order — breaking line-by-line navigation.Change
Removed the auto-column-create branch in the
updatedItemsListloop and unwrapped the surroundingelseso the split-into-existing-column logic runs unconditionally.Preserved behavior
POST /page/:pageId/columnis unchanged.Side effect
pageColumnsUpdate.find(...)is nowpageColumnsUpdate?.find(...). The new block runs for everyupdatedItemsListentry, so the variable can legitimately benull(column-less page). Closes a latent null-deref on column-less pages whose lines get RERUM-versioned by a PUT.Manual testing
A)Column Aunchanged, no new columnsColumn Atracked new parent URI and gained both split childrenhasAnnotationChangescorrectly skipped re-versioningA,B)A(body edit) + numeric child for A;B(body edit) + numeric child for B; 1 brand-new linecolumnsstillnull; existing URI preserved (target unchanged); the newpageColumnsUpdate?.find(...)null-safety branch exercised