Fix manifest import rejecting valid metadata with non-'none' language keys#531
Open
cubap wants to merge 1 commit into
Open
Fix manifest import rejecting valid metadata with non-'none' language keys#531cubap wants to merge 1 commit into
cubap wants to merge 1 commit into
Conversation
d71c513 to
1dc2f4e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The manifest import endpoint (
POST /project/import?createFrom=URL) was rejecting valid IIIF manifests when metadata values used language tags other than"none".Root Cause
validatePayload.jsonly accepted:{ value: "John Doe" }"none"key:{ value: { "none": ["John Doe"] } }Valid IIIF manifests can use any IETF language tag (
"en","fr","la", etc.).Changes
utilities/validatePayload.js— AddedvalidateLanguageMap()andvalidateMetadataField()helpers to accept any IETF language tag in metadatalabelandvaluefields. Refactored duplicated label/value validation into a single parameterized helper.test/local/utility.validation.test.js— Added 5 test cases covering non-"none"language tags, mixed formats, and invalid language maps.Testing
All 14 local tests pass, including the 5 new metadata validation tests.
Related