Add error-handling and token unit tests

Add several unit tests to improve error handling coverage and token middleware behavior. create.test.js and overwrite.test.js gain tests that preserve upstream text on non-409 failures, fall back to a generic RERUM message when upstream .text() throws, and map missing-id successful payloads to 502. error-messenger.test.js replaces res.write with res.end in an existing test and introduces createMockRes plus focused messenger unit tests for headersSent, payload JSON, JSON content-type, and plain-text upstream errors. tokens.test.js adds tests ensuring valid or non-numeric-exp access tokens skip refresh. These changes increase robustness of error-path handling and token refresh logic in tests.

Author: cubap

test/routes/create.test.js

@@ -152,6 +152,24 @@ describe("Check that TinyNode create route propagates upstream and network error
     assert.match(response.text, /A RERUM error occurred/)
   })
 
+  it("Falls back to generic RERUM error text when upstream .text() throws.", async () => {
+    global.fetch = async () => ({
+      ok: false,
+      status: 500,
+      text: async () => {
+        throw new Error("text stream consumed")
+      }
+    })
+
+    const response = await request(routeTester)
+      .post("/create")
+      .set("Content-Type", "application/json")
+      .send({ test: "item" })
+
+    assert.equal(response.statusCode, 502)
+    assert.match(response.text, /A RERUM error occurred/)
+  })
+
   it("Maps successful upstream payload without id fields to 502.", async () => {
     global.fetch = async () => ({
       ok: true,

test/routes/error-messenger.test.js

@@ -16,7 +16,7 @@ describe("Check shared error messenger behavior.  __rest __core", () => {
   it("Returns early when headers are already sent.", async () => {
     const app = express()
     app.get("/test", (req, res, next) => {
-      res.write("partial")
+      res.end("partial")
       next(new Error("late error"))
     })
     app.use(messenger)
@@ -110,3 +110,81 @@ describe("Check shared error messenger behavior.  __rest __core", () => {
     assert.equal(response.body.code, "BAD_INPUT")
   })
 })
+
+function createMockRes(headersSent = false) {
+  const res = {
+    headersSent,
+    statusCode: null,
+    sentText: null,
+    sentJson: null,
+    setHeaders: {},
+    status(code) {
+      this.statusCode = code
+      return this
+    },
+    json(payload) {
+      this.sentJson = payload
+      return this
+    },
+    send(text) {
+      this.sentText = text
+      return this
+    },
+    set(name, value) {
+      this.setHeaders[name] = value
+      return this
+    }
+  }
+  return res
+}
+
+describe("Check shared error messenger unit branches.  __core", () => {
+  it("Returns immediately when headersSent is true.", async () => {
+    const res = createMockRes(true)
+    await messenger(new Error("ignored"), {}, res, () => {})
+    assert.equal(res.statusCode, null)
+    assert.equal(res.sentText, null)
+    assert.equal(res.sentJson, null)
+  })
+
+  it("Sends payload JSON when payload is present.", async () => {
+    const res = createMockRes(false)
+    await messenger({ status: 409, payload: { code: "CONFLICT" } }, {}, res, () => {})
+    assert.equal(res.statusCode, 409)
+    assert.equal(res.sentJson.code, "CONFLICT")
+  })
+
+  it("Uses upstream JSON response when content-type is JSON.", async () => {
+    const res = createMockRes(false)
+    await messenger(
+      {
+        status: 422,
+        headers: { get: () => "application/json; charset=utf-8" },
+        json: async () => ({ detail: "bad request" })
+      },
+      {},
+      res,
+      () => {}
+    )
+    assert.equal(res.statusCode, 422)
+    assert.equal(res.sentJson.detail, "bad request")
+  })
+
+  it("Sends plain text and sets content-type for non-JSON upstream errors.", async () => {
+    const res = createMockRes(false)
+    await messenger(
+      {
+        status: 503,
+        message: "fallback",
+        headers: { get: () => "text/plain" },
+        text: async () => "upstream text"
+      },
+      {},
+      res,
+      () => {}
+    )
+    assert.equal(res.statusCode, 503)
+    assert.equal(res.sentText, "upstream text")
+    assert.equal(res.setHeaders["Content-Type"], "text/plain; charset=utf-8")
+  })
+})

test/routes/overwrite.test.js

@@ -181,6 +181,55 @@ describe("Overwrite network failure behavior.  __rest __core", () => {
       .send({ "@id": rerumTinyTestObjId, testing: "item" })
     assert.equal(response.statusCode, 502)
   })
+
+  it("Preserves upstream text error message for non-409 overwrite failures.", async () => {
+    global.fetch = async () => ({
+      ok: false,
+      status: 503,
+      text: async () => "Upstream overwrite failure"
+    })
+
+    const response = await request(routeTester)
+      .put("/overwrite")
+      .set("Content-Type", "application/json")
+      .send({ "@id": rerumTinyTestObjId, testing: "item" })
+
+    assert.equal(response.statusCode, 502)
+    assert.match(response.text, /Upstream overwrite failure/)
+  })
+
+  it("Falls back to generic RERUM error text when overwrite upstream .text() throws.", async () => {
+    global.fetch = async () => ({
+      ok: false,
+      status: 500,
+      text: async () => {
+        throw new Error("text stream consumed")
+      }
+    })
+
+    const response = await request(routeTester)
+      .put("/overwrite")
+      .set("Content-Type", "application/json")
+      .send({ "@id": rerumTinyTestObjId, testing: "item" })
+
+    assert.equal(response.statusCode, 502)
+    assert.match(response.text, /A RERUM error occurred/)
+  })
+
+  it("Maps successful overwrite payload without id fields to 502.", async () => {
+    global.fetch = async () => ({
+      ok: true,
+      json: async () => ({ testing: "item" })
+    })
+
+    const response = await request(routeTester)
+      .put("/overwrite")
+      .set("Content-Type", "application/json")
+      .send({ "@id": rerumTinyTestObjId, testing: "item" })
+
+    assert.equal(response.statusCode, 502)
+    assert.match(response.text, /A RERUM error occurred/)
+  })
 })
 
 describe("Check that the properly used overwrite endpoints function and interact with RERUM.  __e2e", () => {

test/routes/tokens.test.js

@@ -66,6 +66,35 @@ describe("checkAccessToken middleware behavior.  __core", () => {
     assert.equal(called, 1)
   })
 
+  it("Calls next without refresh when token is valid and not expired.", async () => {
+    process.env.ACCESS_TOKEN = jwtWithExp(Math.floor(Date.now() / 1000) + 3600)
+    global.fetch = async () => {
+      throw new Error("fetch should not be called")
+    }
+
+    let nextError
+    await checkAccessToken({}, {}, err => {
+      nextError = err
+    })
+
+    assert.equal(nextError, undefined)
+  })
+
+  it("Treats non-numeric exp payload as non-expired and skips refresh.", async () => {
+    const payload = Buffer.from(JSON.stringify({ exp: "not-a-number" })).toString("base64")
+    process.env.ACCESS_TOKEN = `header.${payload}.signature`
+    global.fetch = async () => {
+      throw new Error("fetch should not be called")
+    }
+
+    let nextError
+    await checkAccessToken({}, {}, err => {
+      nextError = err
+    })
+
+    assert.equal(nextError, undefined)
+  })
+
   it("Propagates refresh errors to next(err) when token is expired.", async () => {
     process.env.ACCESS_TOKEN = jwtWithExp(Math.floor(Date.now() / 1000) - 60)
     global.fetch = async () => {