Changes while reviewing

Author: thehabes

rest.js

@@ -42,17 +42,18 @@ const checkPatchOverrideSupport = function (req, res) {
  */
 const SKIP_CONTENT_TYPE_METHODS = ["GET", "HEAD", "OPTIONS", "DELETE"]
 const validateContentType = function (req, res, next) {
-    if (SKIP_CONTENT_TYPE_METHODS.includes(req.method) || req.path.startsWith("/release")) {
+    const isReleaseEndpoint = req.path === "/release" || req.path.startsWith("/release/")
+    if (SKIP_CONTENT_TYPE_METHODS.includes(req.method) || isReleaseEndpoint) {
         return next()
     }
     const contentType = (req.get("Content-Type") ?? "").toLowerCase()
-    if (!contentType) {
+    const mimeType = contentType.split(";")[0].trim()
+    if (!mimeType) {
         return next(createExpressError({
             statusCode: 415,
-            statusMessage: `Missing Content-Type header.`
+            statusMessage: `Missing or empty Content-Type header.`
         }))
     }
-    const mimeType = contentType.split(";")[0].trim()
     if (mimeType === "application/json" || mimeType === "application/ld+json") return next()
     const isSearchEndpoint = req.path === "/search" || req.path.startsWith("/search/")
     if (mimeType === "text/plain" && isSearchEndpoint) return next()

routes/__tests__/contentType.test.js

@@ -63,7 +63,7 @@ describe("Content-Type validation middleware", () => {
             .unset("Content-Type")
             .send(Buffer.from('{"test":"data"}'))
         expect(response.statusCode).toBe(415)
-        expect(response.text).toContain("Missing Content-Type header")
+        expect(response.text).toContain("Missing or empty Content-Type header")
     })
 
     it("returns 415 for text/plain on JSON-only endpoint", async () => {