Skip to content

Commit 1c90464

Browse files
committed
Fix createExpressError
1 parent 525b47b commit 1c90464

1 file changed

Lines changed: 7 additions & 14 deletions

File tree

controllers/utils.js

Lines changed: 7 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -100,21 +100,14 @@ const index = function (req, res, next) {
100100
}
101101

102102
function createExpressError(err) {
103-
let error = {}
104-
if (err.code) {
105-
switch (err.code) {
106-
case 11000:
107-
//Duplicate _id key error, specific to SLUG support. This is a Conflict.
108-
error.statusMessage = `The id provided already exists. Please use a different _id or Slug.`
109-
error.statusCode = 409
110-
break
111-
default:
112-
error.statusMessage = "There was a mongo error that prevented this request from completing successfully."
113-
error.statusCode = 500
114-
}
103+
let error = {
104+
statusCode: err.statusCode ?? err.code ?? 500,
105+
statusMessage: err.statusMessage ?? err.message ?? "There was an error that prevented this request from completing successfully."
106+
}
107+
if (err.code === 11000) {
108+
error.statusMessage = `The id provided already exists. Please use a different _id or Slug.`
109+
error.statusCode = 409
115110
}
116-
error.statusCode = err.statusCode ?? err.status ?? 500
117-
error.statusMessage = err.statusMessage ?? err.message ?? "Detected Error"
118111
return error
119112
}
120113

0 commit comments

Comments
 (0)