Changes while reviewing and testing

Author: thehabes

rest.js

@@ -59,7 +59,7 @@ const validateContentType = function (req, res, next) {
     const isSearchEndpoint = req.path === "/search" || req.path.startsWith("/search/")
     if (mimeType === "text/plain" && isSearchEndpoint) return next()
     const acceptedTypes = `application/json or application/ld+json${isSearchEndpoint ? ' or text/plain' : ''}`
-    next(createExpressError({
+    return next(createExpressError({
         statusCode: 415,
         statusMessage: `Unsupported Content-Type: ${contentType}. This endpoint requires ${acceptedTypes}.`
     }))

routes/__tests__/contentType.test.js

@@ -31,6 +31,11 @@ routeTester.delete("/api/delete/:_id", (req, res) => {
     res.status(200).json({ deleted: req.params._id })
 })
 
+// PUT endpoint (like /api/update, /api/bulkUpdate)
+routeTester.put("/api/update", (req, res) => {
+    res.status(200).json({ received: req.body })
+})
+
 // Release endpoint uses PATCH without a JSON body (uses Slug header)
 routeTester.patch("/api/release/:_id", (req, res) => {
     res.status(200).json({ released: req.params._id })
@@ -150,4 +155,22 @@ describe("Content-Type validation middleware", () => {
         expect(response.body.released).toBe("abc123")
     })
 
+    it("accepts application/json on PUT endpoint", async () => {
+        const response = await request(routeTester)
+            .put("/api/update")
+            .set("Content-Type", "application/json")
+            .send({ test: "put-data" })
+        expect(response.statusCode).toBe(200)
+        expect(response.body.received.test).toBe("put-data")
+    })
+
+    it("returns 415 for text/plain on PUT endpoint", async () => {
+        const response = await request(routeTester)
+            .put("/api/update")
+            .set("Content-Type", "text/plain")
+            .send("some text")
+        expect(response.statusCode).toBe(415)
+        expect(response.text).toContain("Unsupported Content-Type")
+    })
+
 })