fix cachiung

Author: thehabes

cache/cache.test.js

@@ -122,6 +122,31 @@ describe('Cache Middleware Tests', () => {
             cacheQuery(mockReq, mockRes, mockNext)
             expect(mockRes.headers['X-Cache']).toBe('MISS')
         })
+
+        it('should create different cache keys for different query bodies', () => {
+            mockReq.method = 'POST'
+            mockReq.query = { limit: '100', skip: '0' }
+            
+            // First request for Annotations
+            mockReq.body = { type: 'Annotation' }
+            cacheQuery(mockReq, mockRes, mockNext)
+            mockRes.json([{ id: '1', type: 'Annotation' }])
+            
+            // Reset mocks for second request
+            mockRes.headers = {}
+            const jsonSpy = jest.fn()
+            mockRes.json = jsonSpy
+            mockNext = jest.fn()
+            
+            // Second request for Person (different body, should be MISS)
+            mockReq.body = { type: 'Person' }
+            cacheQuery(mockReq, mockRes, mockNext)
+            
+            expect(mockRes.headers['X-Cache']).toBe('MISS')
+            expect(mockNext).toHaveBeenCalled()
+            // json was replaced by middleware, so check it wasn't called before next()
+            expect(jsonSpy).not.toHaveBeenCalled()
+        })
     })
 
     describe('cacheSearch middleware', () => {

cache/index.js

@@ -56,7 +56,18 @@ class LRUCache {
             return `id:${params}`
         }
         // For query and search, create a stable key from the params object
-        const sortedParams = JSON.stringify(params, Object.keys(params).sort())
+        // Use a custom replacer to ensure consistent key ordering at all levels
+        const sortedParams = JSON.stringify(params, (key, value) => {
+            if (value && typeof value === 'object' && !Array.isArray(value)) {
+                return Object.keys(value)
+                    .sort()
+                    .reduce((sorted, key) => {
+                        sorted[key] = value[key]
+                        return sorted
+                    }, {})
+            }
+            return value
+        })
         return `${type}:${sortedParams}`
     }