Changes while reviewing

Author: thehabes

rest.js

@@ -32,7 +32,7 @@ const checkPatchOverrideSupport = function (req, res) {
  * reaching controllers, preventing unhandled errors from unparsed or mis-parsed bodies.
  *
  * - Skips validation for methods that don't carry bodies (GET, HEAD, OPTIONS, DELETE)
- * - Skips validation for endpoints that do not use a body (/release)
+ * - Skips validation for endpoints that don't carry bodies (/release)
  * - Allows text/plain for /search endpoints (which accept plain text search terms)
  * - Requires application/json or application/ld+json for all other write endpoints
  * - Returns 415 for missing or unsupported Content-Type

routes/__tests__/contentType.test.js

@@ -26,6 +26,16 @@ routeTester.get("/api/info", (req, res) => {
     res.status(200).json({ info: true })
 })
 
+// DELETE endpoint should pass through without Content-Type validation
+routeTester.delete("/api/delete/:_id", (req, res) => {
+    res.status(200).json({ deleted: req.params._id })
+})
+
+// Release endpoint uses PATCH without a JSON body (uses Slug header)
+routeTester.patch("/api/release/:_id", (req, res) => {
+    res.status(200).json({ released: req.params._id })
+})
+
 // Error handler matching the app's pattern
 routeTester.use(rest.messenger)
 
@@ -118,4 +128,18 @@ describe("Content-Type validation middleware", () => {
         expect(response.body.info).toBe(true)
     })
 
+    it("skips validation for DELETE requests", async () => {
+        const response = await request(routeTester)
+            .delete("/api/delete/abc123")
+        expect(response.statusCode).toBe(200)
+        expect(response.body.deleted).toBe("abc123")
+    })
+
+    it("skips validation for PATCH on release endpoint", async () => {
+        const response = await request(routeTester)
+            .patch("/api/release/abc123")
+        expect(response.statusCode).toBe(200)
+        expect(response.body.released).toBe("abc123")
+    })
+
 })