Migrate tests to node:test and update CI (#273)

* Migrate tests to node:test and update CI

Replace Jest-based test setup with native node:test/assert and update CI. Tests were refactored to use node:test and node:assert (many __tests__ updated), new auth token unit tests added, and routes_mounted.test.js reworked to a data-driven style. The database mock was rewritten to remove Jest-specific APIs and provide a lightweight mock/registry with resetMocks; jest.config.js was removed. GitHub Actions workflows now separate install, test (npm run test:ci) and coverage (npm run coverage:ci) steps. package.json dev tooling and test scripts were adjusted accordingly, and test bootstrap/loader/coverage artifacts were added while placeholder .txt test files were removed.

* Apply suggestions from code review

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

* Delete coverage-inventory.json

* rebranch

* Update cd_dev.yaml

* Update cd_prod.yaml

* hotfix the search test

* Update structural validation + sync strategy in  __tests__/openapi_sync_artifacts.test.js

* dedup test runs on prod

* Bug fixes and tests for critical functionality

* critical functionality tests

* These no longer need the create step for testing

* These no longer need the create step for testing

* Fix exclusion flag

* cleanup

* update start script to avoid dotenv dependency

* Line up contract.  Add HEAD tests because contract requires them.

* load env

* last bit of cleanup and bolstering

* Coverage (#274)

* Add middleware for PATCH override support

Introduce createPatchOverrideMiddleware in rest.js to centralize validation of X-HTTP-Method-Override for POST-to-PATCH requests. Replace duplicated inline checks in routes/patchSet.js, routes/patchUnset.js, and routes/patchUpdate.js with the new middleware (each using a route-specific statusMessage). Also standardize error handling by ending 405 responses with res.status(405).end() and export the new middleware from rest.js.

* End 405 responses and add route wrapper tests

Replace patterns that set status and call next(res) with res.status(405).end() in route fallbacks (routes/query.js, routes/release.js, routes/search.js) to ensure the response is terminated immediately. Add route wrapper tests (routes/__tests__/route_wrappers.test.js) to validate method-override handling, unsupported-method fallbacks, client verify behavior, and API discovery. Include a test coverage inventory (test/coverage-inventory.json) to record current test/coverage state.

* End responses for unsupported-method handlers

Replace next(res) with res.status(405).end() in multiple route fallbacks to ensure responses are terminated immediately (bulkCreate, bulkUpdate, create, delete, history, id, overwrite, putUpdate, since). Update route wrapper tests to import additional routers, add helper asserting fallback behavior on specific paths, and add tests for static/index handlers. Update test coverage inventory to reflect the new/updated tests.

* Guard for bot checks.  Stop releases from hanging on a tree error.

* Changes from review.  Reduce wording locks in tests.

* last bit of cleanup from review

* Introduce ecosystem file and env-loader for RHEL (#276)

* Introduce ecosystem file and env-loader for RHEL

* Introduce ecosystem file and env-loader for RHEL

* changes from testing

* cmon RHEL

* back to 500M

* 100% coverage

* Changes during review

* test: lock down secret name and cp target in sync workflow tests

Adds two regex assertions to each sync-artifact test:
- secrets.OPENAPI must appear verbatim (catches a rename that would
  silently break the receiver checkout step at runtime)
- the literal 'cp source target' line must point at the expected paths
  (already covered for provider sync; now mirrored on shared sync)

Backports improvements developed during TinyNode's parallel sync test
where the same regression class actually bit us this week.

* chore: align RERUM sync workflows with TinyNode/TinyPen pattern

- bump peter-evans/create-pull-request v7 -> v8
- rename receiver checkout path rerum_openapi -> receiver
- add `add-paths`, explicit `base: main`, `ref: main` on receiver checkout
- add `test -f` verify-stub guard on both workflows (receiver stubs exist)
- branch naming automation/sync-rerum-* -> sync/rerum-*
- commit-message/title gain `chore:` prefix
- PR body now matches the bullet-list format used by TinyNode and TinyPen
- update tests to use `path:\s*receiver`, `@v\d+`, and new cp target regex

* Remove claude from authorship lines.  Move contracts/ under openapi/contracts like other repos for consistency

---------

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Bryan Haberberger <bryan.j.haberberger@slu.edu>

Author: 3 people

.github/workflows/cd_dev.yaml

@@ -3,31 +3,18 @@ on:
   pull_request:
     branches: main
 jobs:
-  merge-branch:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: actions/checkout@master
-      - name: Merge with main
-        uses: devmasx/merge-branch@master
-        with:
-          type: now
-          from_branch: main
-          target_branch: ${{ github.head_ref }}
-          github_token: ${{ secrets.OPENAPI }}
-          message: Merge main into this branch to deploy to dev for testing.
   test:
-    needs: merge-branch
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@master
+      - uses: actions/checkout@v4
       - name: Create .env from secrets
         run: echo "${{ secrets.DEV_FULL_ENV }}" > .env
       - name: Setup Node.js
-        uses: actions/setup-node@master
+        uses: actions/setup-node@v4
         with:
           node-version: "24"
       - name: Cache node modules
-        uses: actions/cache@master
+        uses: actions/cache@v4
         env:
           cache-name: cache-node-modules
         with:
@@ -38,14 +25,13 @@ jobs:
             ${{ runner.os }}-build-${{ env.cache-name }}-
             ${{ runner.os }}-build-
             ${{ runner.os }}-
-      - name: Install dependencies and run the test
-        run: |
-          npm install
-          npm run runtest
+      - name: Install dependencies
+        run: npm install
+      - name: Generate coverage report
+        run: npm run coverage:ci
   deploy:
     if: github.event.pull_request.draft == false
     needs:
-      - merge-branch
       - test
     strategy:
       matrix:
@@ -55,7 +41,7 @@ jobs:
           - vlcdhp02
     runs-on: ${{ matrix.machines }}
     steps:
-      - uses: actions/checkout@master
+      - uses: actions/checkout@v4
       - name: Deploy the app on the server
         run: |
           if [[ ! -e /srv/node/logs/rerumv1.txt ]]; then
@@ -70,4 +56,4 @@ jobs:
           git stash
           git pull
           npm install
-          pm2 start -i max bin/rerum_v1.js
+          pm2 startOrReload ecosystem.config.json --env development

.github/workflows/cd_prod.yaml

@@ -6,17 +6,17 @@ jobs:
   test:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@master
+      - uses: actions/checkout@v4
       - name: Create .env from secrets
         run: echo "${{ secrets.PROD_FULL_ENV }}" > .env
       - name: Setup Node.js
-        uses: actions/setup-node@master
+        uses: actions/setup-node@v4
         with:
           node-version: "24"
 
       # Speed up subsequent runs with caching
       - name: Cache node modules
-        uses: actions/cache@master
+        uses: actions/cache@v4
         env:
           cache-name: cache-node-modules
         with:
@@ -27,10 +27,10 @@ jobs:
             ${{ runner.os }}-build-${{ env.cache-name }}-
             ${{ runner.os }}-build-
             ${{ runner.os }}-
-      - name: Install dependencies and run the test
-        run: |
-          npm install
-          npm run runtest
+      - name: Install dependencies
+        run: npm install
+      - name: Generate coverage report
+        run: npm run coverage:ci
   deploy:
     needs: test
     strategy:
@@ -41,7 +41,7 @@ jobs:
           - vlcdhprdp02
     runs-on: ${{ matrix.machines }}
     steps:
-      - uses: actions/checkout@master
+      - uses: actions/checkout@v4
       - name: Deploy the app on the server
         run: |
           if [[ ! -e /srv/node/logs/rerumv1.txt ]]; then
@@ -55,4 +55,4 @@ jobs:
           git stash
           git pull
           npm install
-          pm2 start -i max bin/rerum_v1.js
+          pm2 startOrReload ecosystem.config.json --env production

.github/workflows/sync-core-provider-contract.yml

@@ -1,48 +1,53 @@
-name: Sync Core Provider Contract
+name: Sync RERUM core provider contract
 
 on:
-  workflow_dispatch:
   push:
     branches:
       - main
     paths:
-      - contracts/core-provider.openapi.yaml
+      - openapi/contracts/core-provider.openapi.yaml
       - routes/**
+  workflow_dispatch:
+
+permissions:
+  contents: read
 
 jobs:
-  sync-core-provider-contract:
+  sync:
+    name: Sync RERUM core provider contract
     runs-on: ubuntu-latest
-    permissions:
-      contents: read
     steps:
-      - name: Checkout source repository
+      - name: Checkout rerum_server_nodejs
         uses: actions/checkout@v4
 
-      - name: Checkout rerum_openapi
+      - name: Checkout receiver repository
         uses: actions/checkout@v4
         with:
           repository: cubap/rerum_openapi
+          ref: main
           token: ${{ secrets.OPENAPI }}
-          path: rerum_openapi
+          path: receiver
 
-      - name: Copy provider contract baseline
-        run: |
-          cp contracts/core-provider.openapi.yaml rerum_openapi/seams/tinynode-to-rerum/openapi/baseline.openapi.yaml
+      - name: Verify receiver stub exists
+        run: test -f receiver/seams/tinynode-to-rerum/openapi/baseline.openapi.yaml
 
-      - name: Create sync pull request
-        uses: peter-evans/create-pull-request@v7
+      - name: Copy canonical provider contract
+        run: cp openapi/contracts/core-provider.openapi.yaml receiver/seams/tinynode-to-rerum/openapi/baseline.openapi.yaml
+
+      - name: Create or update sync pull request
+        uses: peter-evans/create-pull-request@v8
         with:
           token: ${{ secrets.OPENAPI }}
-          path: rerum_openapi
-          branch: automation/sync-rerum-core-provider-contract
+          path: receiver
+          add-paths: seams/tinynode-to-rerum/openapi/baseline.openapi.yaml
+          commit-message: "chore: sync RERUM core provider contract"
+          branch: sync/rerum-core-provider-contract
+          base: main
           delete-branch: true
-          commit-message: Sync RERUM core provider contract from rerum_server_nodejs
-          title: Sync RERUM core provider contract from rerum_server_nodejs
+          title: "chore: sync RERUM core provider contract"
           body: |
-            Automated sync from `${{ github.repository }}` at `${{ github.sha }}`.
-
-            Source:
-            - `contracts/core-provider.openapi.yaml`
+            Syncs the canonical RERUM core provider contract from CenterForDigitalHumanities/rerum_server_nodejs.
 
-            Target:
-            - `seams/tinynode-to-rerum/openapi/baseline.openapi.yaml`
+            - Source commit: ${{ github.sha }}
+            - Source artifact: `openapi/contracts/core-provider.openapi.yaml`
+            - Target artifact: `seams/tinynode-to-rerum/openapi/baseline.openapi.yaml`

.github/workflows/sync-rerum-shared-openapi.yml

@@ -1,4 +1,4 @@
-name: Sync shared RERUM OpenAPI artifact
+name: Sync RERUM shared OpenAPI artifact
 
 on:
   push:
@@ -12,37 +12,41 @@ permissions:
   contents: read
 
 jobs:
-  sync-shared-openapi-artifact:
+  sync:
+    name: Sync RERUM shared OpenAPI artifact
     runs-on: ubuntu-latest
     steps:
-      - name: Checkout source repository
+      - name: Checkout rerum_server_nodejs
         uses: actions/checkout@v4
 
-      - name: Checkout rerum_openapi
+      - name: Checkout receiver repository
         uses: actions/checkout@v4
         with:
           repository: cubap/rerum_openapi
+          ref: main
           token: ${{ secrets.OPENAPI }}
-          path: rerum_openapi
+          path: receiver
 
-      - name: Copy shared artifact
-        run: |
-          cp openapi/components/rerum-shared-components.openapi.yaml rerum_openapi/schemas/openapi/rerum-shared-components.openapi.yaml
+      - name: Verify receiver stub exists
+        run: test -f receiver/schemas/openapi/rerum-shared-components.openapi.yaml
 
-      - name: Create sync pull request
-        uses: peter-evans/create-pull-request@v7
+      - name: Copy canonical shared artifact
+        run: cp openapi/components/rerum-shared-components.openapi.yaml receiver/schemas/openapi/rerum-shared-components.openapi.yaml
+
+      - name: Create or update sync pull request
+        uses: peter-evans/create-pull-request@v8
         with:
           token: ${{ secrets.OPENAPI }}
-          path: rerum_openapi
-          branch: automation/sync-rerum-shared-openapi-artifact
+          path: receiver
+          add-paths: schemas/openapi/rerum-shared-components.openapi.yaml
+          commit-message: "chore: sync RERUM shared OpenAPI artifact"
+          branch: sync/rerum-shared-openapi
+          base: main
           delete-branch: true
-          commit-message: Sync shared RERUM OpenAPI artifact from rerum_server_nodejs
-          title: Sync shared RERUM OpenAPI artifact from rerum_server_nodejs
+          title: "chore: sync RERUM shared OpenAPI artifact"
           body: |
-            Automated sync from `${{ github.repository }}` at `${{ github.sha }}`.
-
-            Source:
-            - `openapi/components/rerum-shared-components.openapi.yaml`
+            Syncs the canonical RERUM shared OpenAPI artifact from CenterForDigitalHumanities/rerum_server_nodejs.
 
-            Target:
-            - `schemas/openapi/rerum-shared-components.openapi.yaml`
+            - Source commit: ${{ github.sha }}
+            - Source artifact: `openapi/components/rerum-shared-components.openapi.yaml`
+            - Target artifact: `schemas/openapi/rerum-shared-components.openapi.yaml`