Refactor if/else statements to use guard clauses for improved readability (#206)

* Initial plan

* Refactor route files to use guard clauses instead of if/else

Co-authored-by: cubap <1119165+cubap@users.noreply.github.com>

* Refactor app.js maintenance mode check to use guard clause

Co-authored-by: cubap <1119165+cubap@users.noreply.github.com>

* Update package-lock.json

* Invert patch override check in POST routes

Simplify POST handlers for patch routes by inverting the rest.checkPatchOverrideSupport condition and moving the controller invocation out of the conditional in routes/patchSet.js, routes/patchUnset.js, and routes/patchUpdate.js. Behavior is preserved: if patch-override is not supported respond with 405, otherwise call the corresponding controller. This reduces nesting and improves readability.

* no diff

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: cubap <1119165+cubap@users.noreply.github.com>
Co-authored-by: Bryan Haberberger <bryan.j.haberberger@slu.edu>
Co-authored-by: Patrick Cuba <cubap@slu.edu>

Author: 3 people

app.js

@@ -72,10 +72,9 @@ app.use(express.static(path.join(__dirname, 'public')))
 app.all('*_', (req, res, next) => {
   if(process.env.DOWN === "true"){
       res.status(503).json({"message":"RERUM v1 is down for updates or maintenance at this time.  We apologize for the inconvenience.  Try again later."})
+      return
   }
-  else{
-      next() //pass on to the next app.use
-  }
+  next() //pass on to the next app.use
 })
 
 app.use('/', indexRouter)

routes/patchSet.js

@@ -8,14 +8,13 @@ import rest from '../rest.js'
 router.route('/')
     .patch(auth.checkJwt, rest.verifyJsonContentType, controller.patchSet)
     .post(auth.checkJwt, rest.verifyJsonContentType, (req, res, next) => {
-        if (rest.checkPatchOverrideSupport(req, res)) {
-            controller.patchSet(req, res, next)
-        }
-        else {
+        if (!rest.checkPatchOverrideSupport(req, res)) {
             res.statusMessage = 'Improper request method for updating, please use PATCH to add new keys to this object.'
             res.status(405)
             next(res)
+            return
         }
+        controller.patchSet(req, res, next)
     }) 
     .all((req, res, next) => {
         res.statusMessage = 'Improper request method for updating, please use PATCH to add new keys to this object.'

routes/patchUnset.js

@@ -8,14 +8,13 @@ import rest from '../rest.js'
 router.route('/')
     .patch(auth.checkJwt, rest.verifyJsonContentType, controller.patchUnset)
     .post(auth.checkJwt, rest.verifyJsonContentType, (req, res, next) => {
-        if (rest.checkPatchOverrideSupport(req, res)) {
-            controller.patchUnset(req, res, next)
-        }
-        else {
+        if (!rest.checkPatchOverrideSupport(req, res)) {
             res.statusMessage = 'Improper request method for updating, please use PATCH to remove keys from this object.'
             res.status(405)
             next(res)
+            return
         }
+        controller.patchUnset(req, res, next)
     }) 
     .all((req, res, next) => {
         res.statusMessage = 'Improper request method for updating, please use PATCH to remove keys from this object.'

routes/patchUpdate.js

@@ -9,14 +9,13 @@ import auth from '../auth/index.js'
 router.route('/')
     .patch(auth.checkJwt, rest.verifyJsonContentType, controller.patchUpdate) 
     .post(auth.checkJwt, rest.verifyJsonContentType, (req, res, next) => {
-        if (rest.checkPatchOverrideSupport(req, res)) {
-            controller.patchUpdate(req, res, next)
-        }
-        else {
+        if (!rest.checkPatchOverrideSupport(req, res)) {
             res.statusMessage = 'Improper request method for updating, please use PATCH to alter the existing keys this object.'
             res.status(405)
             next(res)
+            return
         }
+        controller.patchUpdate(req, res, next)
     }) 
     .all((req, res, next) => {
         res.statusMessage = 'Improper request method for updating, please use PATCH to alter existing keys on this object.'