Simplify overbuilt conditionals in auth module (#210)

* Initial plan

* Simplify overbuilt conditionals in auth module

Co-authored-by: cubap <1119165+cubap@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: cubap <1119165+cubap@users.noreply.github.com>
Co-authored-by: Patrick Cuba <cubap@slu.edu>
Co-authored-by: Bryan Haberberger <bryan.j.haberberger@slu.edu>

Author: 3 people

auth/index.js

@@ -81,10 +81,9 @@ const generateNewAccessToken = async (req, res, next) => {
         if(tokenObj.error){
             console.error(tokenObj.error_description)
             res.status(500).send(tokenObj.error_description)
+            return
         }
-        else{
-            res.status(200).send(tokenObj) 
-        }
+        res.status(200).send(tokenObj)
     }
     catch (e) {
         console.error(e.response ? e.response.body : e.message ? e.message : e)
@@ -127,10 +126,9 @@ const generateNewRefreshToken = async (req, res, next) => {
         if(tokenObj.error){
             console.error(tokenObj.error_description)
             res.status(500).send(tokenObj.error_description)
+            return
         }
-        else{
-            res.status(200).send(tokenObj) 
-        }
+        res.status(200).send(tokenObj)
      } 
      catch (e) {
         console.error(e.response ? e.response.body : e.message ? e.message : e)