Skip to content

We don't name our ports, this is all unneeded #185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thehabes merged 3 commits into from
Apr 15, 2025
Merged

We don't name our ports, this is all unneeded #185

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f825bbe
We don't name our ports, this is all unneeded
cubap Nov 25, 2024
6235134
Merge branch 'main' into cubap/issue158
cubap Apr 14, 2025
9f70670
Merge branch 'main' into cubap/issue158
thehabes Apr 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 2 additions & 24 deletions bin/rerum_v1.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ dotenv.config()
* Get port from environment and store in Express.
*/

var port = normalizePort(process.env.PORT ?? '3001')
var port = process.env.PORT ?? 3001
app.set('port', port)

/**
Expand All @@ -40,26 +40,6 @@ server.keepAliveTimeout = 8 * 1000 //8 seconds
// Ensure the headersTimeout is set higher than the keepAliveTimeout due to this nodejs regression bug: https://github.com/nodejs/node/issues/27363
server.headersTimeout = 8.5 * 1000 //8 seconds

/**
* Normalize a port into a number, string, or false.
*/

function normalizePort(val) {
const portCheck = parseInt(val, 10)

if (isNaN(portCheck)) {
// named pipe
return val
}

if (portCheck >= 0) {
// port number
return portCheck
}

return false
}

/**
* Event listener for HTTP server "error" event.
*/
Expand All @@ -69,9 +49,7 @@ function onError(error) {
throw error
}

var bind = typeof port === 'string'
? 'Pipe ' + port
: 'Port ' + port
var bind = `Port ${port}`

// handle specific listen errors with friendly messages
switch (error.code) {
Expand Down