Merge pull request #1013 from Vlad0n20/fix/ENG-11346

fix(ENG-11346): show placeholder in cedar-derived filter dropdowns

Author: adlius

src/app/shared/components/search-filters/search-filters.component.html

@@ -24,7 +24,7 @@
 
             <osf-generic-filter
               [filterOperator]="filter.operator"
-              [placeholder]="FILTER_PLACEHOLDERS[filter.key] || '' | translate"
+              [placeholder]="getPlaceholderKey(filter) | translate: { label: filter.label }"
               [options]="filter.options || []"
               [selectedOptions]="selectedOptions()[filter.key] || []"
               [searchResults]="filterSearchResults()[filter.key] || []"

src/app/shared/components/search-filters/search-filters.component.spec.ts

@@ -283,4 +283,18 @@ describe('SearchFiltersComponent', () => {
 
     expect(component.selectedOptionValues()).toEqual({});
   });
+
+  it('should return specific placeholder key for known filter keys', () => {
+    fixture.detectChanges();
+
+    const filter = { key: 'subject', label: 'Subject' } as DiscoverableFilter;
+    expect(component.getPlaceholderKey(filter)).toBe('common.search.filterPlaceholders.subject');
+  });
+
+  it('should return generic placeholder key for CEDAR-derived filters not in FILTER_PLACEHOLDERS', () => {
+    fixture.detectChanges();
+
+    const cedarFilter = { key: 'Collected Type Choices', label: 'Collected Type Choices' } as DiscoverableFilter;
+    expect(component.getPlaceholderKey(cedarFilter)).toBe('common.search.filterPlaceholders.generic');
+  });
 });

src/app/shared/components/search-filters/search-filters.component.ts

@@ -128,6 +128,10 @@ export class SearchFiltersComponent {
     this.filterOptionSelected.emit({ filter, filterOption: isChecked ? [option] : [] });
   }
 
+  getPlaceholderKey(filter: DiscoverableFilter): string {
+    return FILTER_PLACEHOLDERS[filter.key] ?? 'common.search.filterPlaceholders.generic';
+  }
+
   private scrollPanelIntoView(key: string) {
     of(key)
       .pipe(delay(this.SCROLL_DELAY_MS), takeUntilDestroyed(this.destroyRef))

src/assets/i18n/en.json

@@ -105,7 +105,8 @@
         "isPartOfCollection": "Select collection",
         "dateCreated": "Select date",
         "creator": "Creator name",
-        "resourceType": "Select resource type"
+        "resourceType": "Select resource type",
+        "generic": "Select {{label}}"
       }
     },
     "sort": {