fix(files): fixed comments

Author: nsemets

src/app/features/files/components/files-tree-explorer/files-tree-explorer.component.ts

@@ -73,7 +73,7 @@ export class FilesTreeExplorerComponent {
   readonly storage = input.required<FileLabelModel | null>();
 
   readonly totalCount = input<number>(0);
-  readonly isLoading = input<boolean>();
+  readonly isLoading = input<boolean>(false);
   readonly resourceId = input.required<string>();
   readonly resourceType = input<CurrentResourceType>(CurrentResourceType.Projects);
   readonly viewOnly = input<boolean>(true);

src/app/features/files/components/move-file-dialog/move-file-dialog.component.ts

@@ -184,14 +184,14 @@ export class MoveFileDialogComponent {
         tap(() => this.completeMove()),
         finalize(() => {
           this.config.header = this.translateService.instant('files.dialogs.moveFile.title');
+          this.isFilesUpdating.set(false);
         }),
         takeUntilDestroyed(this.destroyRef)
       )
       .subscribe();
   }
 
   private completeMove(): void {
-    this.isFilesUpdating.set(false);
     this.actions.setCurrentFolder(this.initialFolder);
     this.actions.setMoveDialogCurrentFolder(null);
     this.dialogRef.close(true);

src/app/features/files/pages/file-detail/file-detail.component.ts

@@ -150,7 +150,7 @@ export class FileDetailComponent implements OnDestroy {
   selectedTab = FileDetailTab.Details;
 
   fileGuid = '';
-  fileVersion = '';
+  fileVersion = signal('');
 
   embedItems = [
     {
@@ -190,8 +190,8 @@ export class FileDetailComponent implements OnDestroy {
 
   readonly headerTitle = computed(() => {
     const fileName = this.file()?.name ?? '';
-    if (!this.fileVersion) return fileName;
-    return `${fileName} (${this.translateService.instant('project.wiki.version.title')} ${this.fileVersion})`;
+    if (!this.fileVersion()) return fileName;
+    return `${fileName} (${this.translateService.instant('project.wiki.version.title')} ${this.fileVersion()})`;
   });
 
   private readonly metaTagsData = computed(() => {
@@ -233,8 +233,8 @@ export class FileDetailComponent implements OnDestroy {
   }
 
   onOpenRevision(version: string): void {
-    if (this.fileVersion !== version) {
-      this.fileVersion = version;
+    if (this.fileVersion() !== version) {
+      this.fileVersion.set(version);
       this.getIframeLink(version);
       this.isIframeLoading = true;
     }

src/app/features/files/pages/files/files.component.html

@@ -13,10 +13,11 @@
         <p-select
           class="w-full"
           inputId="in_label"
+          variant="filled"
           [options]="rootFoldersOptions()"
+          [disabled]="isButtonDisabled()"
           [(ngModel)]="currentRootFolder"
           (onChange)="handleRootFolderChange($event.value)"
-          variant="filled"
         />
       }
     </div>

src/app/features/project/overview/components/files-widget/files-widget.component.ts

@@ -18,6 +18,7 @@ import {
   PLATFORM_ID,
   signal,
 } from '@angular/core';
+import { takeUntilDestroyed } from '@angular/core/rxjs-interop';
 import { Router } from '@angular/router';
 
 import { FileProvider } from '@osf/features/files/constants';
@@ -170,11 +171,14 @@ export class FilesWidgetComponent {
       return;
     }
 
-    this.filesService.getFileGuid(file.id).subscribe((file) => {
-      if (file.guid) {
-        this.openFile(file.guid);
-      }
-    });
+    this.filesService
+      .getFileGuid(file.id)
+      .pipe(takeUntilDestroyed(this.destroyRef))
+      .subscribe((file) => {
+        if (file.guid) {
+          this.openFile(file.guid);
+        }
+      });
   }
 
   onLoadFiles(event: FilePageLinkModel) {

src/styles/overrides/tree.scss

@@ -72,5 +72,9 @@
         }
       }
     }
+
+    .p-tree-loading-icon {
+      color: var(--pr-blue-1);
+    }
   }
 }