Skip to content

Commit 40cf2a9

Browse files
committed
feat(hotfix): Fix tests
1 parent c4db0e9 commit 40cf2a9

1 file changed

Lines changed: 3 additions & 17 deletions

File tree

src/app/features/preprints/services/preprint-draft-deletion.service.spec.ts

Lines changed: 3 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -44,12 +44,10 @@ describe('PreprintDraftDeletionService', () => {
4444
expect(service).toBeTruthy();
4545
});
4646

47-
it('should open confirm delete and run delete, reset, toast, navigate on confirm', () => {
48-
const onDelete = vi.fn();
47+
it('should open confirm delete and run reset, toast, navigate on confirm', () => {
4948
const onReset = vi.fn();
5049

5150
service.confirmDeleteDraft({
52-
onDelete,
5351
onReset,
5452
redirectUrl: '/preprints',
5553
});
@@ -63,34 +61,22 @@ describe('PreprintDraftDeletionService', () => {
6361
const { onConfirm } = confirmationMock.confirmDelete.mock.calls[0][0];
6462
onConfirm();
6563

66-
expect(onDelete).toHaveBeenCalled();
6764
expect(onReset).toHaveBeenCalled();
6865
expect(toastMock.showSuccess).toHaveBeenCalledWith('preprints.preprintStepper.deleteDraft.success');
6966
expect(routerMock.navigateByUrl).toHaveBeenCalledWith('/preprints');
7067
});
7168

72-
it('should allow canDeactivate and skip deleteOnDestroy after confirmed delete', () => {
73-
const onDelete = vi.fn();
69+
it('should allow canDeactivate after confirmed delete', () => {
7470
const onReset = vi.fn();
7571

76-
service.confirmDeleteDraft({ onDelete, onReset, redirectUrl: '/x' });
72+
service.confirmDeleteDraft({ onReset, redirectUrl: '/x' });
7773
const { onConfirm } = confirmationMock.confirmDelete.mock.calls[0][0];
7874
onConfirm();
7975

8076
expect(service.canDeactivate(false)).toBe(true);
81-
82-
const destroyDelete = vi.fn();
83-
service.deleteOnDestroyIfNeeded(destroyDelete);
84-
expect(destroyDelete).not.toHaveBeenCalled();
8577
});
8678

8779
it('should return canDeactivate true when submitted', () => {
8880
expect(service.canDeactivate(true)).toBe(true);
8981
});
90-
91-
it('should call deleteOnDestroy when not yet deleted', () => {
92-
const destroyDelete = vi.fn();
93-
service.deleteOnDestroyIfNeeded(destroyDelete);
94-
expect(destroyDelete).toHaveBeenCalled();
95-
});
9682
});

0 commit comments

Comments
 (0)