Skip to content

Commit 44583e9

Browse files
authored
[ENG-11004] Account Setting: Code key is displayed instead of button text (#989)
- Ticket: https://openscience.atlassian.net/browse/ENG-11004 - Feature flag: n/a ## Purpose The second button shows text ...accountsSettings.common.buttons... , the second button should display the proper translated label ## Summary of Changes add settings.accountSettings.common.buttons.configure translation to en.json
1 parent f4ea516 commit 44583e9

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

src/app/features/settings/account-settings/components/two-factor-auth/two-factor-auth.component.spec.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -89,7 +89,7 @@ describe('TwoFactorAuthComponent', () => {
8989
expect(confirmationService.confirmAccept).toHaveBeenCalledWith({
9090
headerKey: 'settings.accountSettings.twoFactorAuth.configure.title',
9191
messageKey: 'settings.accountSettings.twoFactorAuth.configure.description',
92-
acceptLabelKey: 'settings.accountSettings.common.buttons.configure',
92+
acceptLabelKey: 'common.buttons.configure',
9393
onConfirm: expect.any(Function),
9494
});
9595

src/app/features/settings/account-settings/components/two-factor-auth/two-factor-auth.component.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ export class TwoFactorAuthComponent {
5555
this.customConfirmationService.confirmAccept({
5656
headerKey: 'settings.accountSettings.twoFactorAuth.configure.title',
5757
messageKey: 'settings.accountSettings.twoFactorAuth.configure.description',
58-
acceptLabelKey: 'settings.accountSettings.common.buttons.configure',
58+
acceptLabelKey: 'common.buttons.configure',
5959
onConfirm: () => {
6060
this.loaderService.show();
6161
this.actions.enableTwoFactorAuth().subscribe(() => this.loaderService.hide());

0 commit comments

Comments
 (0)