test(files): added unit tests

Author: nsemets

src/app/features/admin-institutions/pages/institutions-projects/institutions-projects.component.spec.ts

@@ -2,8 +2,6 @@ import { Store } from '@ngxs/store';
 
 import { MockComponents, MockProvider } from 'ng-mocks';
 
-import { DynamicDialogRef } from 'primeng/dynamicdialog';
-
 import { of, Subject, throwError } from 'rxjs';
 
 import { Mock } from 'vitest';
@@ -35,6 +33,7 @@ import {
 import { MOCK_USER } from '@testing/mocks/data.mock';
 import { provideOSFCore } from '@testing/osf.testing.provider';
 import {
+  CustomDialogServiceMock,
   CustomDialogServiceMockBuilder,
   CustomDialogServiceMockType,
 } from '@testing/providers/custom-dialog-provider.mock';
@@ -65,11 +64,8 @@ describe('InstitutionsProjectsComponent', () => {
 
   const mockInstitution = { ...MOCK_ADMIN_INSTITUTIONS_INSTITUTION, id: 'inst-1' };
 
-  function createDialogRef<T>(onClose$: Subject<T>): DynamicDialogRef {
-    return {
-      onClose: onClose$.asObservable(),
-      close: vi.fn(),
-    } as unknown as DynamicDialogRef;
+  function createDialogRef<T>(onClose$: Subject<T>) {
+    return CustomDialogServiceMock.dialogRefWithClose(onClose$.asObservable());
   }
 
   function createIconClickEvent(): TableIconClickEvent {

src/app/features/files/components/file-keywords/file-keywords.component.spec.ts

@@ -126,4 +126,26 @@ describe('FileKeywordsComponent', () => {
 
     expect(store.dispatch).not.toHaveBeenCalled();
   });
+
+  it('should not dispatch update when cannot edit tags', () => {
+    setup({
+      selectorOverrides: [{ selector: FilesSelectors.hasWriteAccess, value: false }],
+    });
+    (store.dispatch as Mock).mockClear();
+
+    component.deleteTag('tag1');
+
+    expect(store.dispatch).not.toHaveBeenCalled();
+  });
+
+  it('should not dispatch update when file guid is missing', () => {
+    setup({
+      selectorOverrides: [{ selector: FilesSelectors.getOpenedFile, value: null }],
+    });
+    (store.dispatch as Mock).mockClear();
+
+    component.deleteTag('tag1');
+
+    expect(store.dispatch).not.toHaveBeenCalled();
+  });
 });

src/app/features/files/components/file-metadata/file-metadata.component.spec.ts

@@ -2,6 +2,8 @@ import { Store } from '@ngxs/store';
 
 import { MockProvider } from 'ng-mocks';
 
+import { Subject } from 'rxjs';
+
 import { Mock } from 'vitest';
 
 import { ComponentFixture, TestBed } from '@angular/core/testing';
@@ -38,10 +40,11 @@ describe('FileMetadataComponent', () => {
 
   interface SetupOverrides extends BaseSetupOverrides {
     url?: string;
+    dialogServiceMock?: CustomDialogServiceMockType;
   }
 
   function setup(options: SetupOverrides = {}) {
-    customDialogService = CustomDialogServiceMock.simple();
+    customDialogService = options.dialogServiceMock ?? CustomDialogServiceMock.simple();
     const defaultSignals = [
       { selector: FilesSelectors.getFileCustomMetadata, value: mockFileMetadata },
       { selector: FilesSelectors.isFileMetadataLoading, value: false },
@@ -127,4 +130,68 @@ describe('FileMetadataComponent', () => {
     setup({ url: '/test?view_only=abc' });
     expect(component.hasViewOnly).toBe(true);
   });
+
+  it('should open metadata url when file guid exists', () => {
+    setup({ routeParams: { fileGuid: 'guid-123' } });
+    const focus = vi.fn();
+    const openSpy = vi.spyOn(window, 'open').mockReturnValue({ focus } as unknown as Window);
+
+    component.downloadFileMetadata();
+
+    expect(openSpy).toHaveBeenCalledWith(expect.stringMatching(/\/metadata\/guid-123$/));
+    expect(focus).toHaveBeenCalled();
+  });
+
+  it('should not open metadata url when file guid is missing', () => {
+    setup({ routeParams: {} });
+    const openSpy = vi.spyOn(window, 'open').mockReturnValue(null);
+
+    component.downloadFileMetadata();
+
+    expect(openSpy).not.toHaveBeenCalled();
+  });
+
+  it('should call setFileMetadata when edit dialog closes with metadata', () => {
+    const metadataChange$ = new Subject<PatchFileMetadata>();
+    customDialogService = CustomDialogServiceMock.create()
+      .withOpen(
+        vi.fn().mockReturnValue({
+          onClose: metadataChange$,
+          close: vi.fn(),
+        })
+      )
+      .build();
+    setup({ dialogServiceMock: customDialogService });
+    const setFileMetadataSpy = vi.spyOn(component, 'setFileMetadata');
+    const formValues: PatchFileMetadata = {
+      title: 'Edited',
+      description: 'Edited desc',
+      resource_type_general: 'Dataset',
+      language: 'en',
+    };
+
+    component.openEditFileMetadataDialog();
+    metadataChange$.next(formValues);
+
+    expect(setFileMetadataSpy).toHaveBeenCalledWith(formValues);
+  });
+
+  it('should not call setFileMetadata when edit dialog closes with empty value', () => {
+    const metadataChange$ = new Subject<PatchFileMetadata | null>();
+    customDialogService = CustomDialogServiceMock.create()
+      .withOpen(
+        vi.fn().mockReturnValue({
+          onClose: metadataChange$,
+          close: vi.fn(),
+        })
+      )
+      .build();
+    setup({ dialogServiceMock: customDialogService });
+    const setFileMetadataSpy = vi.spyOn(component, 'setFileMetadata');
+
+    component.openEditFileMetadataDialog();
+    metadataChange$.next(null);
+
+    expect(setFileMetadataSpy).not.toHaveBeenCalled();
+  });
 });

src/app/features/files/components/file-select-destination/file-select-destination.component.spec.ts

@@ -1,29 +1,158 @@
+import { Store } from '@ngxs/store';
+
 import { MockComponent } from 'ng-mocks';
 
+import { Mock } from 'vitest';
+
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 
+import { SelectComponent } from '@osf/shared/components/select/select.component';
+import { SupportedFeature } from '@osf/shared/enums/addon-supported-features.enum';
+import { ResourceType } from '@osf/shared/enums/resource-type.enum';
+import { UserPermissions } from '@osf/shared/enums/user-permissions.enum';
+import { FileFolderModel } from '@osf/shared/models/files/file-folder.model';
+import { NodeShortInfoModel } from '@osf/shared/models/nodes/node-with-children.model';
+
+import { MOCK_CONFIGURED_ADDON } from '@testing/mocks/configured-addon.mock';
+import { OSF_FILE_MOCK } from '@testing/mocks/osf-file.mock';
 import { provideOSFCore } from '@testing/osf.testing.provider';
+import {
+  BaseSetupOverrides,
+  mergeSignalOverrides,
+  provideMockStore,
+  SignalOverride,
+} from '@testing/providers/store-provider.mock';
 
-import { SelectComponent } from '../../../../shared/components/select/select.component';
+import { FileProvider } from '../../constants/file-provider.constants';
+import {
+  FilesSelectors,
+  GetMoveDialogConfiguredStorageAddons,
+  GetMoveDialogRootFolders,
+  GetStorageSupportedFeatures,
+} from '../../store';
 
 import { FileSelectDestinationComponent } from './file-select-destination.component';
 
-describe.skip('FileSelectDestinationComponent', () => {
+interface SetupOverrides extends BaseSetupOverrides {
+  projectId?: string;
+  storageProvider?: string;
+  components?: NodeShortInfoModel[];
+  areComponentsLoading?: boolean;
+}
+
+describe('FileSelectDestinationComponent', () => {
   let component: FileSelectDestinationComponent;
   let fixture: ComponentFixture<FileSelectDestinationComponent>;
+  let store: Store;
+
+  const rootFolder: FileFolderModel = {
+    ...OSF_FILE_MOCK,
+    id: 'root-1',
+    name: 'OSF Storage',
+    provider: FileProvider.OsfStorage,
+  };
+
+  const components: NodeShortInfoModel[] = [
+    { id: 'project-1', title: 'Project 1', isPublic: true, permissions: [UserPermissions.Write] },
+    {
+      id: 'component-1',
+      title: 'Component 1',
+      isPublic: true,
+      permissions: [UserPermissions.Write],
+      parentId: 'project-1',
+    },
+    { id: 'readonly-1', title: 'Readonly', isPublic: true, permissions: [UserPermissions.Read], parentId: 'project-1' },
+  ];
+
+  function setup(overrides: SetupOverrides = {}) {
+    const defaultSignals: SignalOverride[] = [
+      { selector: FilesSelectors.getMoveDialogRootFolders, value: [rootFolder] },
+      { selector: FilesSelectors.isMoveDialogRootFoldersLoading, value: false },
+      {
+        selector: FilesSelectors.getMoveDialogConfiguredStorageAddons,
+        value: [{ ...MOCK_CONFIGURED_ADDON, id: 'addon-1', externalServiceName: FileProvider.OsfStorage }],
+      },
+      { selector: FilesSelectors.isMoveDialogConfiguredStorageAddonsLoading, value: false },
+      { selector: FilesSelectors.isMoveDialogFilesLoading, value: false },
+      {
+        selector: FilesSelectors.getStorageSupportedFeatures,
+        value: { [FileProvider.OsfStorage]: [SupportedFeature.AddUpdateFiles] },
+      },
+    ];
 
-  beforeEach(() => {
     TestBed.configureTestingModule({
       imports: [FileSelectDestinationComponent, MockComponent(SelectComponent)],
-      providers: [provideOSFCore()],
+      providers: [
+        provideOSFCore(),
+        provideMockStore({ signals: mergeSignalOverrides(defaultSignals, overrides.selectorOverrides) }),
+      ],
     });
 
+    store = TestBed.inject(Store);
     fixture = TestBed.createComponent(FileSelectDestinationComponent);
     component = fixture.componentInstance;
+    fixture.componentRef.setInput('projectId', overrides.projectId ?? 'project-1');
+    fixture.componentRef.setInput('storageProvider', overrides.storageProvider ?? FileProvider.OsfStorage);
+    fixture.componentRef.setInput('components', overrides.components ?? components);
+    fixture.componentRef.setInput('areComponentsLoading', overrides.areComponentsLoading ?? false);
     fixture.detectChanges();
-  });
+  }
 
   it('should create', () => {
+    setup();
     expect(component).toBeTruthy();
   });
+
+  it('should load storage addons on init and request supported features', () => {
+    setup();
+    const calls = (store.dispatch as Mock).mock.calls.map((c) => c[0]);
+
+    expect(calls).toContainEqual(new GetMoveDialogRootFolders('project-1', ResourceType.Project));
+    expect(calls).toContainEqual(new GetMoveDialogConfiguredStorageAddons('project-1'));
+    expect(calls).toContainEqual(new GetStorageSupportedFeatures('addon-1', FileProvider.OsfStorage));
+  });
+
+  it('should emit project selection and reload storage addons on project change', () => {
+    setup();
+    const emitSpy = vi.spyOn(component.selectProject, 'emit');
+    (store.dispatch as Mock).mockClear();
+
+    component.onChangeProject('project-2');
+
+    expect(emitSpy).toHaveBeenCalledWith('project-2');
+    expect(store.dispatch).toHaveBeenCalledWith(new GetMoveDialogRootFolders('project-2', ResourceType.Project));
+    expect(store.dispatch).toHaveBeenCalledWith(new GetMoveDialogConfiguredStorageAddons('project-2'));
+  });
+
+  it('should update current root folder and emit storage selection on storage change', () => {
+    setup();
+    const emitSpy = vi.spyOn(component.selectStorage, 'emit');
+
+    component.onStorageChange('root-1');
+
+    expect(component.currentRootFolder()?.folder.id).toBe('root-1');
+    expect(emitSpy).toHaveBeenCalled();
+  });
+
+  it('should include only write-access nodes in options', () => {
+    setup();
+    const values = component.options().map((o) => o.value);
+
+    expect(values).toContain('project-1');
+    expect(values).toContain('component-1');
+    expect(values).not.toContain('readonly-1');
+  });
+
+  it('should detect add update feature by provider', () => {
+    setup();
+
+    expect(component.hasAddUpdateFeature(FileProvider.OsfStorage)).toBe(true);
+    expect(component.hasAddUpdateFeature('dropbox')).toBe(false);
+  });
+
+  it('should expose loading state when component loading is true', () => {
+    setup({ areComponentsLoading: true });
+
+    expect(component.isLoading()).toBe(true);
+  });
 });

src/app/features/files/components/file-select-destination/file-select-destination.component.ts

@@ -77,7 +77,6 @@ export class FileSelectDestinationComponent implements OnInit {
   });
 
   initialSetup = true;
-  private storageRequestId = 0;
   currentRootFolder = model<FileLabelModel | null>(null);
 
   readonly selectedProject = computed(() => this.options().find((c) => c.value === this.projectId()) || null);
@@ -131,7 +130,6 @@ export class FileSelectDestinationComponent implements OnInit {
   }
 
   private getStorageAddons(projectId: string) {
-    const requestId = ++this.storageRequestId;
     forkJoin({
       rootFolders: this.actions.getRootFolders(projectId, ResourceType.Project),
       addons: this.actions.getConfiguredStorageAddons(projectId),
@@ -150,10 +148,6 @@ export class FileSelectDestinationComponent implements OnInit {
         })
       )
       .subscribe(() => {
-        if (requestId !== this.storageRequestId) {
-          return;
-        }
-
         const storages = this.storageAddons();
         const currentStorage = storages.find((s) => s.folder.provider === this.storageProvider()) || storages[0];