Skip to content

Commit 58c998c

Browse files
committed
chore(pr-updates): updated the files based on pr feedback
1 parent 50dd7af commit 58c998c

2 files changed

Lines changed: 10 additions & 8 deletions

File tree

.github/workflows/review.yml

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3,9 +3,7 @@ name: Require at least one approval
33

44
on:
55
pull_request:
6-
types: [opened, reopened, ready_for_review, synchronize]
7-
pull_request_review:
8-
types: [submitted, edited, dismissed]
6+
types: [opened, reopened, ready_for_review, synchronize, edited]
97

108
jobs:
119
check-approval:

docs/i18n.md

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -18,13 +18,13 @@ The OSF Angular project uses [`@ngx-translate/core`](https://github.com/ngx-tran
1818

1919
All strings rendered to users—whether in HTML templates or dynamically via Angular components—must be sourced from the centralized i18n JSON files located in:
2020

21-
**IMPORTANT**
22-
The OSF application must maintain 100% translation coverage, as it is a requirement of grant funding that supports a globally distributed user base.
23-
2421
```
2522
src/app/i18n/
2623
```
2724

25+
**IMPORTANT**
26+
The OSF application must maintain 100% translation coverage, as it is a requirement of grant funding that supports a globally distributed user base.
27+
2828
## Integration: `@ngx-translate/core`
2929

3030
To support multilingual content, the following module is included globally:
@@ -74,7 +74,7 @@ The structure should be **namespaced by feature or component** for maintainabili
7474
{
7575
"home": {
7676
"title": "Welcome to OSF",
77-
"subtTtle": "Your research. Your control."
77+
"subTitle": "Your research. Your control."
7878
},
7979
"login": {
8080
"email": "Email Address",
@@ -85,11 +85,15 @@ The structure should be **namespaced by feature or component** for maintainabili
8585

8686
Avoid deeply nested keys, and always use consistent camel-casing and key naming for reuse and clarity.
8787

88+
**Note**
89+
90+
The `common section` in the en.json file stores frequently used phrases to prevent one-off duplicate translations.
91+
8892
## Source of Truth: `en.json` Only
8993

9094
All translation key additions and updates must be made **only** in the `src/app/i18n/en.json` file.
9195

92-
> Other language files (e.g., `fr.json`, `es.json`) must **not** be modified manually. These translations will be handle internally by the OSF Angular team.
96+
> Other language files (e.g., `fr.json`, `es.json`) must **not** be modified by non-OSF engineers. These translations will be handle internally by the OSF Angular team.
9397
9498
This ensures consistency across translations and prevents desynchronization between supported languages.
9599

0 commit comments

Comments
 (0)