fix(ENG-11334): fix comments

Author: Vlad0n20

src/app/shared/stores/global-search/global-search.state.spec.ts

@@ -94,16 +94,6 @@ describe('GlobalSearchState', () => {
       expect(mockGetFilterOptions).not.toHaveBeenCalled();
     });
 
-    it('should skip the API call for a CEDAR filter found only in extraFilters (before first fetch)', () => {
-      const { store, mockGetFilterOptions } = setup();
-      store.dispatch(new SetExtraFilters([CEDAR_FILTER]));
-      // Intentionally no FetchResources — state.filters is still empty
-
-      store.dispatch(new LoadFilterOptions(CEDAR_FILTER.key));
-
-      expect(mockGetFilterOptions).not.toHaveBeenCalled();
-    });
-
     it('should set isLoaded to true for a CEDAR filter when short-circuiting', () => {
       const { store } = setup();
 

src/app/shared/stores/global-search/global-search.state.ts

@@ -293,11 +293,17 @@ export class GlobalSearchState {
     const { extraFilters } = ctx.getState();
     const apiFilterKeys = new Set(response.filters.map((f) => f.key));
 
+    const extraByKey = new Map(extraFilters.map((ef) => [ef.key, ef]));
+
     const merged = response.filters.map((apiFilter) => {
-      const cedarExtra = extraFilters.find((ef) => ef.key === apiFilter.key);
-      return cedarExtra?.cedarPropertyIri
-        ? { ...apiFilter, cedarPropertyIri: cedarExtra.cedarPropertyIri, options: cedarExtra.options }
-        : apiFilter;
+      const cedarExtra = extraByKey.get(apiFilter.key);
+      if (!cedarExtra) return apiFilter;
+
+      return {
+        ...apiFilter,
+        cedarPropertyIri: cedarExtra.cedarPropertyIri,
+        ...(cedarExtra.options !== undefined && { options: cedarExtra.options }),
+      };
     });
     const extraFiltersNotInApi = extraFilters.filter((ef) => !apiFilterKeys.has(ef.key));