Skip to content

Commit af7caca

Browse files
authored
Merge pull request #1004 from adlius/fix-search
feat(es2): fix search page again
2 parents a408a54 + 50c5984 commit af7caca

5 files changed

Lines changed: 9 additions & 3 deletions

File tree

src/app/features/collections/components/collections-discover/collections-discover.component.spec.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@ const MOCK_COLLECTION_IRI = 'http://localhost:8000/v2/collections/collection-1/'
3333

3434
const MOCK_COLLECTION_PROVIDER = {
3535
...MOCK_PROVIDER,
36+
iri: MOCK_COLLECTION_IRI,
3637
primaryCollection: { id: 'collection-1', type: 'collections' },
3738
requiredMetadataTemplate: null,
3839
};
@@ -249,7 +250,7 @@ describe('CollectionsDiscoverComponent', () => {
249250
) as SetDefaultFilterValue;
250251

251252
expect(setDefaultFilter).toBeDefined();
252-
expect(setDefaultFilter.filterKey).toBe('isContainedBy');
253+
expect(setDefaultFilter.filterKey).toBe('isPartOfCollection');
253254
expect(setDefaultFilter.value).toBe(MOCK_COLLECTION_IRI);
254255
});
255256

src/app/features/collections/components/collections-discover/collections-discover.component.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,10 +161,10 @@ export class CollectionsDiscoverComponent {
161161
private setupShareTroveSearchEffect(): void {
162162
effect(() => {
163163
const provider = this.collectionProvider();
164-
const collectionIri = this.collectionDetails()?.iri;
164+
const collectionIri = provider?.iri;
165165
if (!this.useShareTroveSearch() || !provider || !collectionIri || this.defaultSearchFiltersInitialized()) return;
166166

167-
this.actions.setDefaultFilterValue('isContainedBy', collectionIri);
167+
this.actions.setDefaultFilterValue('isPartOfCollection', collectionIri);
168168

169169
if (provider.requiredMetadataTemplate?.attributes?.template) {
170170
const extraFilters = CedarTemplateFilterMapper.fromTemplate(

src/app/shared/mappers/collections/collections.mapper.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ export class CollectionsMapper {
5050
favicon: response.attributes.assets.favicon,
5151
}
5252
: {},
53+
iri: response.links?.iri,
5354
shareSource: response.attributes.share_source,
5455
sharePublishType: response.attributes.share_publish_type,
5556
permissions: response.attributes.permissions,

src/app/shared/models/collections/collections-json-api.model.ts

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,9 @@ import { UserDataErrorResponseJsonApi } from '../user/user-json-api.model';
1010
export interface CollectionProviderResponseJsonApi {
1111
id: string;
1212
type: string;
13+
links?: {
14+
iri?: string;
15+
};
1316
attributes: CollectionsProviderAttributesJsonApi;
1417
embeds: {
1518
brand: {

src/app/shared/models/collections/collections.model.ts

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ import { ProjectModel } from '../projects/projects.model';
88
import { BaseProviderModel } from '../provider/provider.model';
99

1010
export interface CollectionProvider extends BaseProviderModel {
11+
iri?: string;
1112
assets: {
1213
style?: string;
1314
squareColorTransparent?: string;

0 commit comments

Comments
 (0)