fix(files): fixed some issues and updated tests

Author: nsemets

src/app/features/files/components/files-tree-explorer/files-tree-explorer.component.html

@@ -39,7 +39,7 @@ <h3 class="font-normal mb-4 text-no-transform">{{ 'files.emptyState' | translate
             } @else {
               <div class="flex flex-column align-items-center justify-content-center">
                 <i class="fa-solid fa-cloud-arrow-up text-5xl"></i>
-                <p class="text-xl">{{ 'files.dropText' | translate }}</p>
+                <p class="text-xl text-center">{{ 'files.dropText' | translate }}</p>
               </div>
             }
           </div>

src/app/features/files/components/files-tree-explorer/files-tree-explorer.component.spec.ts

@@ -1,7 +1,5 @@
 import { MockComponents, MockProvider } from 'ng-mocks';
 
-import { Mock } from 'vitest';
-
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 import { Router } from '@angular/router';
 
@@ -24,6 +22,10 @@ import { FileModelMock } from '@testing/mocks/file.model.mock';
 import { provideOSFCore } from '@testing/osf.testing.provider';
 import { DataciteServiceMock, DataciteServiceMockType } from '@testing/providers/datacite.service.mock';
 import { FilesServiceMock, FilesServiceMockType } from '@testing/providers/files-service.mock';
+import {
+  FilesShareEmbedServiceMock,
+  FilesShareEmbedServiceMockType,
+} from '@testing/providers/files-share-embed-provider.mock';
 import { RouterMockBuilder, RouterMockType } from '@testing/providers/router-provider.mock';
 import { ViewOnlyLinkHelperMock, ViewOnlyLinkHelperMockType } from '@testing/providers/view-only-link-helper.mock';
 
@@ -37,10 +39,7 @@ describe('FilesTreeExplorerComponent', () => {
   let routerMock: RouterMockType;
   let filesService: FilesServiceMockType;
   let dataciteService: DataciteServiceMockType;
-  let filesShareEmbedService: Pick<FilesShareEmbedService, 'getShareLink' | 'copyEmbedToClipboard'> & {
-    getShareLink: Mock;
-    copyEmbedToClipboard: Mock;
-  };
+  let filesShareEmbedService: FilesShareEmbedServiceMockType;
   let viewOnlyHelper: ViewOnlyLinkHelperMockType;
 
   const currentFolder: FileFolderModel = {
@@ -66,10 +65,7 @@ describe('FilesTreeExplorerComponent', () => {
     filesService = FilesServiceMock.simple();
     dataciteService = DataciteServiceMock.simple();
     viewOnlyHelper = ViewOnlyLinkHelperMock.simple(false);
-    filesShareEmbedService = {
-      getShareLink: vi.fn(),
-      copyEmbedToClipboard: vi.fn(),
-    };
+    filesShareEmbedService = FilesShareEmbedServiceMock.simple();
 
     TestBed.configureTestingModule({
       imports: [

src/app/features/files/components/move-file-dialog/move-file-dialog.component.html

@@ -15,7 +15,7 @@
   <div class="flex flex-column gap-2">
     <div class="files-table flex flex-column relative">
       @if (previousFolder()) {
-        <div class="files-table-row previous-folder px-3">
+        <div class="files-table-row px-3">
           <p-button
             class="link-btn-no-padding w-full h-full"
             styleClass="w-full h-full justify-content-start"

src/app/features/files/components/move-file-row/move-file-row.component.html

@@ -13,7 +13,7 @@
       </div>
     } @else {
       <p-button
-        class="filename-link link-btn-no-padding overflow-ellipsis font-normal"
+        class="filename-link link-btn-no-padding font-normal"
         icon="fas fa-folder"
         severity="secondary"
         [link]="true"

src/app/features/files/components/move-file-row/move-file-row.component.spec.ts

@@ -1,8 +1,12 @@
+import { MockComponent } from 'ng-mocks';
+
 import { ComponentFixture, TestBed } from '@angular/core/testing';
 
+import { IconComponent } from '@osf/shared/components/icon/icon.component';
 import { FileKind } from '@osf/shared/enums/file-kind.enum';
 import { FileModel } from '@osf/shared/models/files/file.model';
 
+import { FileModelMock } from '@testing/mocks/file.model.mock';
 import { provideOSFCore } from '@testing/osf.testing.provider';
 
 import { MoveFileRowComponent } from './move-file-row.component';
@@ -11,37 +15,18 @@ describe('MoveFileRowComponent', () => {
   let component: MoveFileRowComponent;
   let fixture: ComponentFixture<MoveFileRowComponent>;
 
-  const createFile = (kind: FileKind, name: string): FileModel => ({
-    id: `${kind}-id`,
-    guid: null,
-    name,
-    kind,
-    path: `/${name}`,
-    size: 1,
-    materializedPath: `/${name}`,
-    dateModified: '2026-01-01',
-    extra: {
-      hashes: { md5: 'md5', sha256: 'sha256' },
-      downloads: 0,
-    },
-    links: {
-      info: '/info',
-      move: '/move',
-      upload: '/upload',
-      delete: '/delete',
-      download: '/download',
-      render: '/render',
-      html: '/html',
-      self: '/self',
-    },
-    filesLink: null,
-    previousFolder: false,
-    provider: 'osfstorage',
-  });
+  const createFile = (kind: FileKind, name: string): FileModel =>
+    FileModelMock.simple({
+      id: `${kind}-id`,
+      name,
+      kind,
+      path: `/${name}`,
+      materializedPath: `/${name}`,
+    });
 
-  const setup = (item: FileModel, isBlocked = false, isIndented = false) => {
+  function setup(item: FileModel, isBlocked = false, isIndented = false) {
     TestBed.configureTestingModule({
-      imports: [MoveFileRowComponent],
+      imports: [MoveFileRowComponent, MockComponent(IconComponent)],
       providers: [provideOSFCore()],
     });
 
@@ -51,14 +36,14 @@ describe('MoveFileRowComponent', () => {
     fixture.componentRef.setInput('isBlocked', isBlocked);
     fixture.componentRef.setInput('isIndented', isIndented);
     fixture.detectChanges();
-  };
+  }
 
   it('should render file row as disabled', () => {
     setup(createFile(FileKind.File, 'paper.pdf'));
 
     expect(component.isFile()).toBe(true);
     expect(fixture.nativeElement.textContent).toContain('paper.pdf');
-    expect(fixture.nativeElement.querySelector('.fa-file')).toBeTruthy();
+    expect(fixture.nativeElement.querySelector('.filename-link.disabled')?.textContent?.trim()).toBe('paper.pdf');
     expect(fixture.nativeElement.querySelector('button')).toBeNull();
   });
 
@@ -67,7 +52,8 @@ describe('MoveFileRowComponent', () => {
 
     expect(component.isFile()).toBe(false);
     expect(fixture.nativeElement.textContent).toContain('docs');
-    expect(fixture.nativeElement.querySelector('.fa-folder')).toBeTruthy();
+    expect(fixture.nativeElement.querySelector('.filename-link.disabled')).toBeNull();
+    expect(fixture.nativeElement.querySelector('p-button')).toBeNull();
     expect(fixture.nativeElement.querySelector('button')).toBeNull();
   });