feat(ENG-9818): fix comments

Author: Vlad0n20

src/app/features/collections/components/collections-discover/collections-discover.component.html

@@ -37,7 +37,7 @@ <h1 class="collections-heading flex align-items-center">{{ collectionProvider()?
     </div>
 
     <div class="content-container flex-1">
-      @if (useShtrovSearch) {
+      @if (useShareTroveSearch) {
         @if (defaultSearchFiltersInitialized()) {
           <osf-global-search [searchControlInput]="searchControl" />
         }

src/app/features/collections/components/collections-discover/collections-discover.component.spec.ts

@@ -129,8 +129,8 @@ describe('CollectionsDiscoverComponent', () => {
       expect(component).toBeTruthy();
     });
 
-    it('should set useShtrovSearch to false', () => {
-      expect(component.useShtrovSearch).toBe(false);
+    it('should set useShareTroveSearch to false', () => {
+      expect(component.useShareTroveSearch).toBe(false);
     });
 
     it('should initialize with default values', () => {
@@ -197,9 +197,9 @@ describe('CollectionsDiscoverComponent', () => {
   });
 
   describe('shtrove mode (collectionSubmissionWithCedar = true)', () => {
-    it('should set useShtrovSearch to true', () => {
+    it('should set useShareTroveSearch to true', () => {
       const { component } = setup({ collectionSubmissionWithCedar: true });
-      expect(component.useShtrovSearch).toBe(true);
+      expect(component.useShareTroveSearch).toBe(true);
     });
 
     it('should initialize default search filters', () => {

src/app/features/collections/components/collections-discover/collections-discover.component.ts

@@ -78,7 +78,7 @@ export class CollectionsDiscoverComponent {
   providerId = signal<string>('');
   defaultSearchFiltersInitialized = signal(false);
 
-  readonly useShtrovSearch: boolean = this.environment.collectionSubmissionWithCedar;
+  readonly useShareTroveSearch = this.environment.collectionSubmissionWithCedar;
 
   collectionProvider = select(CollectionsSelectors.getCollectionProvider);
   collectionDetails = select(CollectionsSelectors.getCollectionDetails);
@@ -107,8 +107,8 @@ export class CollectionsDiscoverComponent {
     this.initializeProvider();
     this.setupBrandingEffect();
 
-    if (this.useShtrovSearch) {
-      this.setupShtrovSearchEffect();
+    if (this.useShareTroveSearch) {
+      this.setupShareTroveSearchEffect();
     } else {
       this.setupCollectionDetailsEffect();
       this.setupUrlSyncEffect();
@@ -119,7 +119,7 @@ export class CollectionsDiscoverComponent {
     this.destroyRef.onDestroy(() => {
       if (this.isBrowser) {
         this.actions.clearCollections();
-        if (this.useShtrovSearch) {
+        if (this.useShareTroveSearch) {
           this.actions.resetSearchState();
         }
         this.headerStyleHelper.resetToDefaults();
@@ -133,7 +133,7 @@ export class CollectionsDiscoverComponent {
   }
 
   onSearchTriggered(searchValue: string): void {
-    if (!this.useShtrovSearch) {
+    if (!this.useShareTroveSearch) {
       this.actions.setSearchValue(searchValue);
       this.actions.setPageNumber('1');
     }
@@ -161,15 +161,14 @@ export class CollectionsDiscoverComponent {
     });
   }
 
-  private setupShtrovSearchEffect(): void {
+  private setupShareTroveSearchEffect(): void {
     effect(() => {
       const provider = this.collectionProvider();
       const collectionId = this.primaryCollectionId();
 
       if (!provider || !collectionId || this.defaultSearchFiltersInitialized()) return;
 
       const collectionIri = `${this.environment.apiDomainUrl}/v2/collections/${collectionId}/`;
-      // TODO(ENG-9818): verify 'isContainedBy' property path against shtrove API before shipping
       this.actions.setDefaultFilterValue('isContainedBy', collectionIri);
 
       if (provider.requiredMetadataTemplate?.attributes?.template) {