Merge pull request #1007 from adlius/fix-add-metadata-page

feat(es2): Only show non-cedar templates when adding metadata

Author: adlius

src/app/features/metadata/models/cedar-metadata-template.model.ts

@@ -7,6 +7,7 @@ export interface CedarMetadataDataTemplateJsonApi {
     schema_name: string;
     cedar_id: string;
     template: CedarTemplate;
+    is_for_collections: boolean;
   };
 }
 
@@ -76,6 +77,7 @@ export interface CedarMetadataTemplate {
     schema_name: string;
     cedar_id: string;
     template: CedarTemplate;
+    is_for_collections: boolean;
   };
 }
 

src/app/features/metadata/pages/add-metadata/add-metadata.component.spec.ts

@@ -78,7 +78,7 @@ describe('AddMetadataComponent', () => {
         MockProvider(ToastService, toastService),
         provideMockStore({
           signals: [
-            { selector: MetadataSelectors.getCedarTemplates, value: mockCedarTemplates },
+            { selector: MetadataSelectors.getCedarTemplatesExcludingCollections, value: mockCedarTemplates },
             { selector: MetadataSelectors.getCedarRecords, value: mockCedarRecords },
             { selector: MetadataSelectors.getCedarTemplatesLoading, value: false },
             { selector: MetadataSelectors.getCedarRecord, value: { data: mockRecord } },

src/app/features/metadata/pages/add-metadata/add-metadata.component.ts

@@ -56,7 +56,7 @@ export class AddMetadataComponent implements OnInit {
   selectedTemplate: CedarMetadataDataTemplateJsonApi | null = null;
   existingRecord: CedarMetadataRecordData | null = null;
 
-  readonly cedarTemplates = select(MetadataSelectors.getCedarTemplates);
+  readonly cedarTemplates = select(MetadataSelectors.getCedarTemplatesExcludingCollections);
   readonly cedarRecords = select(MetadataSelectors.getCedarRecords);
   readonly cedarTemplatesLoading = select(MetadataSelectors.getCedarTemplatesLoading);
   readonly cedarRecord = select(MetadataSelectors.getCedarRecord);

src/app/features/metadata/store/metadata.selectors.ts

@@ -41,6 +41,16 @@ export class MetadataSelectors {
     return state.cedarTemplates.data;
   }
 
+  @Selector([MetadataState])
+  static getCedarTemplatesExcludingCollections(state: MetadataStateModel) {
+    const templates = state.cedarTemplates.data;
+    if (!templates) return null;
+    return {
+      ...templates,
+      data: templates.data.filter((t) => !t.attributes.is_for_collections),
+    };
+  }
+
   @Selector([MetadataState])
   static getCedarTemplatesLoading(state: MetadataStateModel) {
     return state.cedarTemplates.isLoading;

src/testing/data/collections/cedar-metadata.mock.ts

@@ -32,6 +32,7 @@ export const MOCK_CEDAR_TEMPLATE: CedarMetadataDataTemplateJsonApi = {
       properties: {},
       _ui: { order: [], propertyLabels: {}, propertyDescriptions: {} },
     },
+    is_for_collections: false,
   },
 };
 

src/testing/mocks/cedar-metadata-data-template-json-api.mock.ts

@@ -43,5 +43,6 @@ export const CEDAR_METADATA_DATA_TEMPLATE_JSON_API_MOCK: CedarMetadataTemplate =
         },
       },
     },
+    is_for_collections: false,
   },
 };