[Hotfix][ENG-4649] Reset page QP on new search text (#1974)

* Reset page QP on new search text

* Remove page query-param

Author: futa-ikeda

app/institutions/discover/controller.ts

@@ -14,7 +14,7 @@ export default class InstitutionDiscoverController extends Controller {
     @tracked sort?: string =  '-relevance';
     @tracked resourceType?: ResourceTypeFilterValue | null = null;
 
-    queryParams = ['cardSearchText', 'page', 'sort', 'resourceType'];
+    queryParams = ['cardSearchText', 'sort', 'resourceType'];
 
     get defaultQueryOptions() {
         return {

app/preprints/discover/controller.ts

@@ -17,7 +17,7 @@ export default class PreprintDiscoverController extends Controller {
     @tracked cardSearchText?: string = '';
     @tracked sort?: string =  '-relevance';
 
-    queryParams = ['cardSearchText', 'page', 'sort'];
+    queryParams = ['cardSearchText', 'sort'];
 
     get defaultQueryOptions() {
         return {

app/search/controller.ts

@@ -7,15 +7,13 @@ export default class SearchController extends Controller {
     @tracked q?: string = '';
     @tracked sort?: string =  '-relevance';
     @tracked resourceType?: ResourceTypeFilterValue | null = null;
-    @tracked page?: string = '';
 
-    queryParams = ['q', 'page', 'sort', 'resourceType'];
+    queryParams = ['q', 'sort', 'resourceType'];
 
     @action
     onSearch(queryOptions: OnSearchParams) {
         this.q = queryOptions.cardSearchText;
         this.sort = queryOptions.sort;
         this.resourceType = queryOptions.resourceType;
-        this.page = queryOptions.page;
     }
 }

lib/osf-components/addon/components/search-page/component.ts

@@ -234,7 +234,7 @@ export default class SearchPage extends Component<SearchArgs> {
             this.totalResultCount = searchResult.totalResultCount === ShareMoreThanTenThousand ? '10,000+' :
                 searchResult.totalResultCount;
             if (this.args.onSearch) {
-                this.args.onSearch({cardSearchText, sort, resourceType, page});
+                this.args.onSearch({cardSearchText, sort, resourceType});
             }
         } catch (e) {
             this.toast.error(e);
@@ -252,6 +252,7 @@ export default class SearchPage extends Component<SearchArgs> {
     @waitFor
     async doDebounceSearch() {
         await timeout(searchDebounceTime);
+        this.page = '';
         taskFor(this.search).perform();
     }