This repository was archived by the owner on Apr 14, 2026. It is now read-only.
Feature/pbs 25 05#2540
Merged
Merged
Conversation
…hould add more text, however, I found the text already in the code.
…t the date exists in the format. I also commented on some logic I am unable to produce
## Purpose Fix a caching issue related to removing a supplement ## Summary of Changes Added a try/catch removed the node ## Side Effects Should prevent future issues https://openscience.atlassian.net/browse/ENG-5326
- Ticket: [ENG-5027] ## Purpose - Show deleted user's names in contributor fields ## Summary of Changes - Add logic in osf-serializer to finagle deleted user data onto contributor model - Update contributor-list/contributor component to look for deleted user data in case ContributorModel.user relationship is undefined ## Side Effects - _may_ be introducing a new error when setting head tags, specifically these lines where we try to sparse-load contributors and their users https://github.com/CenterForOpenScience/ember-osf-web/blob/master/app/preprints/detail/route.ts#L155-L158 ## QA Notes - Verify that deleted users (probably via the admin app GDPR delete them?) have their names shown in preprint detail page [ENG-5027]: https://openscience.atlassian.net/browse/ENG-5027
…mber-osf-web into upstream/pbs-25-05
… to resubmit (#2528) - Ticket: https://openscience.atlassian.net/browse/ENG-7472 ## Purpose Make it possible to resubmit rejected preprint versions
* Send metrics for unverified DOIs * fix(dcut): avoid resolving preprint guids when `itemDoi` is set to an empty string, do not try finding a DOI for that item by more convoluted means -- let the empty be. * fix: avoid error tracking preprint download --------- Co-authored-by: abram axel booth <boothaa@gmail.com>
…t code to the correct page
…#2534) ## Purpose - Prevent bug that prevents a write-user from updating registration metadata ## Summary of Changes - Remove subjects relationship data from PUT request payload - Subjects are only editable by registration admins, so having this included in the request payload was preventing write users from editing metadata https://openscience.atlassian.net/browse/ENG-7712
## Purpose - Fix issues with write-users not being able to update registration metadata due to subjects being added to request payloads ## Summary of Changes - Undo changes made in this PR #2534 - Update the node metadata form to show subject picker only for admin users - Only show selected subjects for write and read users https://openscience.atlassian.net/browse/ENG-7712
- Ticket: [ENG-6927] ## Purpose Issues with css. I thought the default "display: flex" was column??? ## Summary of Changes Add "flex-direction: column" to the main wrapper and removed it from the mobile class.
…nt selected folder (#2536) - Ticket: [ENG-7714] [ENG-7025] - Feature flag: n/a ## Purpose - Fix issue where Configure Addon page's Save button was enabled when users had not yet selected a root folder - Improve UX so users will see their currently selected root folder at the top of the page and root folder will be selected when navigating back to a view that shows the current root folder selection ## Summary of Changes - Update logic for when Save button is disabled (`selectFolder` was an action, `selectedFolder` is the correct variable to use 😮💨 ) - Update confusing `hasRootFolder` property name to `requiresRootFolder` - Add a "Selected folder:" display to help users know which folder is the currently selected root - Add logic to pre-select radio button if the shown item is the currently selected root folder [ENG-7714]: https://openscience.atlassian.net/browse/ENG-7714 [ENG-7025]: https://openscience.atlassian.net/browse/ENG-7025
bp-cos
approved these changes
Apr 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Merge the feature branch pbs-25-05 to develop.