[ENG-8370] Fix for local setup#385
Closed
opaduchak wants to merge 1 commit into
Closed
Conversation
opaduchak
changed the title
opaduchak
commented
Jul 16, 2025
| MFR_IDENTIFYING_HEADER = config.get('MFR_IDENTIFYING_HEADER', 'X-Cos-Mfr-Render-Request') | ||
| MFR_ACTION_HEADER = config.get('MFR_ACTION_HEADER', 'X-Cos-Mfr-Request-Action') | ||
|
|
||
| OSF_DOMAIN = config.get('MFR_OSF_DOMAIN', None) |
Collaborator
Author
There was a problem hiding this comment.
None should be changed to '192.168.168.167' locally
Collaborator
Author
|
Closed as CenterForOpenScience/osf.io#11233 provides better solution |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/ENG-8370
Purpose
Fix MFR not being able to render files on webpage in docker-compose
Changes
Added host substitution in osf provider to silently forward all requests from localhost to 192.168.168.167
Side effects
None, but local config should contain a host to point to
QA Notes
Deployment Notes