[ENG-7607][ENG-8357] Feature/unoserver integration#388
Merged
felliott merged 1 commit intoJul 25, 2025
Merged
Conversation
opaduchak
reviewed
Jul 24, 2025
opaduchak
left a comment
opaduchak
left a comment
Collaborator
There was a problem hiding this comment.
Two small issues, rather than that, looks great!
Comment on lines
+19
to
+22
| client = UnoClient( | ||
| server=UNOSERVER_HOST, | ||
| port=int(UNOSERVER_PORT), | ||
| ) |
Collaborator
There was a problem hiding this comment.
Please update osf.io docker-compose.yml to use unoserver instead of unoconv
Contributor
There was a problem hiding this comment.
It was done in seperate PR, as it had a seperate ticket -> CenterForOpenScience/osf.io#11228
| markdown = "3.8.0" | ||
| certifi = "2025.1.31" | ||
| unoconv = "0.9.0" | ||
| unoserver = ">=3.2,<4.0" |
Collaborator
There was a problem hiding this comment.
It's better to pin dependencies to specific patch, to have more predictable environment and instalations
Contributor
There was a problem hiding this comment.
pinned to latest version (3.3.2) in latest commit
* pin unoserver to specific version v3.3.2 (latest) * Update MFR code to use unoserver * PIL error fix * static files 404 error fix
opaduchak
approved these changes
Jul 25, 2025
opaduchak
left a comment
opaduchak
left a comment
Collaborator
There was a problem hiding this comment.
Looks Great! Thanks for all the effort!
felliott
force-pushed
the
feature/unoserver-integration
branch
from
a0d6b1e to
ed1b701
Compare
felliott
merged commit 8aa8251
into
CenterForOpenScience:feature/buff-worms
1 check passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/ENG-8356
https://openscience.atlassian.net/browse/ENG-7606
https://openscience.atlassian.net/browse/ENG-7607
https://openscience.atlassian.net/browse/ENG-8357
Purpose
MFR Update unconv to unoserver (update poetry dependencies)
MFR Update code to use unoserver
Changes
replace UnoconvExporter code to unoserver
Side effects
QA Notes
Deployment Notes