[ENG-8423] [Reference PR] [Don't Merge] apply ruff and pre-commit for autoformatting#395
Merged
felliott merged 2 commits intoAug 21, 2025
Conversation
cslzchen
requested changes
Aug 4, 2025
cslzchen
left a comment
cslzchen
left a comment
Contributor
There was a problem hiding this comment.
Looks good with a few suggestions ⭐
cslzchen
approved these changes
Aug 7, 2025
cslzchen
left a comment
cslzchen
left a comment
Contributor
There was a problem hiding this comment.
Looks good 🎆 . As discussed, this will likely be post release. Keeping this PR and the ticket open for reference. We need to create a brand new PR once MFR is released.
cslzchen
changed the title
felliott
force-pushed
the
feature/ENG--8423
branch
from
505c0bd to
5fd07dc
Compare
felliott
merged commit a080e58
into
CenterForOpenScience:feature/buff-worms
4 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/ENG-8423
Purpose
apply ruff and pre-commit for autoformatting to keep code style in one standart
Changes
setup needed packages,
apply ruff styling to existing mfr code using
ruff format .commandadd 'pre-commit' support to apply auto ruff formatting
pre-commit installcommand run is needed on first runSide effects
ruff tells about raise inside except, is it ok , if we change it somehow it may break some business logic?
QA Notes
Deployment Notes