Refactor SSO availability validation in InstitutionForm and override post method in InstitutionChangeForm for custom behavior

Author: Ostap-Zherebetskyi

admin/institutions/forms.py

@@ -22,13 +22,6 @@ def clean(self):
                 if self.cleaned_data['sso_availability'] != SSOAvailability.HIDDEN.value:
                     self.add_error('sso_availability', 'Inactive must be HIDDEN')
 
-            else:
-                if self.cleaned_data['sso_availability'] not in [
-                    SSOAvailability.PUBLIC.value,
-                    SSOAvailability.HIDDEN.value
-                ]:
-                    self.add_error('sso_availability', 'Active must be PUBLIC or HIDDEN')
-
 
 class InstitutionalMetricsAdminRegisterForm(forms.Form):
     """ A form that finds an existing OSF User, and grants permissions to that

admin/institutions/views.py

@@ -119,6 +119,7 @@ def get_success_url(self, *args, **kwargs):
         return reverse_lazy('institutions:detail', kwargs={'institution_id': self.kwargs.get('institution_id')})
 
     def post(self, request, *args, **kwargs):
+        # Override post method from ProcessFormView due to custom  behavior
         self.object = self.get_object()
         form = self.get_form()
         if form.is_valid():