Skip to content

Commit b602c17

Browse files
authored
[ENG-9111] Reverted locking access_requests_enabled behind api version (#11349)
* reverted locking access_requests_enabled behind api version in NodeSerializer * fixed test for access_request
1 parent faad331 commit b602c17

2 files changed

Lines changed: 2 additions & 4 deletions

File tree

api/nodes/serializers.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ class NodeSerializer(TaxonomizableSerializerMixin, JSONAPISerializer):
272272
fork = ser.BooleanField(read_only=True, source='is_fork')
273273
collection = ser.BooleanField(read_only=True, source='is_collection')
274274
tags = ValuesListField(attr_name='name', child=ser.CharField(), required=False)
275-
access_requests_enabled = ShowIfVersion(ser.BooleanField(read_only=False, required=False), min_version='2.0', max_version='2.8')
275+
access_requests_enabled = ser.BooleanField(read_only=True, required=False)
276276
node_license = NodeLicenseSerializer(required=False, source='license')
277277
# 'analytics_key' can be removed after another version release.
278278
analytics_key = ShowIfAdminScopeOrAnonymous(ser.CharField(read_only=True, default=''))

api_tests/nodes/views/test_node_detail.py

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -358,11 +358,9 @@ def test_preprint_field(self, app, user, user_two, project_public, url_public):
358358
assert res.status_code == 200
359359
assert res.json['data']['attributes']['preprint'] is False
360360

361-
def test_shows_access_requests_enabled_field_based_on_version(self, app, user, project_public, url_public):
361+
def test_shows_access_requests_enabled_field(self, app, user, project_public, url_public):
362362
url = url_public + '?version=latest'
363363
res = app.get(url, auth=user.auth)
364-
assert 'access_requests_enabled' not in res.json['data']['attributes']
365-
res = app.get(url_public + '?version=2.8', auth=user.auth)
366364
assert 'access_requests_enabled' in res.json['data']['attributes']
367365

368366
def test_node_shows_correct_templated_from_count(self, app, user, project_public, url_public):

0 commit comments

Comments
 (0)