Reference PR for release 26.9.0#11731
Closed
cslzchen wants to merge 5 commits into
Closed
Conversation
Misc. bug fixes and improvements
Hotfix for registration failing to become public after approval
Hotfix to avoid 502 on creating preprint version from rejected version
* allow angular url to be in next_url * renamed constant * added tests and debug mode * angular url * added tests and debug mode * edited comments * added sso_in_progress field to Institution model * Add tests * Add SSO availability field and update institution reactivation logic * Update SSO availability logic and add tests for institution deactivation * Apply suggestions from @cslzchen * Add CAS login URL property and implement copy modal in institution detail view * Refactor SSO URL generation and clean up unused code in institution model * Add management command to backfill SSO availability * Add sso_availability field to InstitutionSerializer and enable filtering by sso_availability in InstitutionList view * Add SSO Availability column to institutions list view * Add get_sso_institutions method to InstitutionManager and update InstitutionList queryset filtering * Add test for default filter excluding institutions with hidden SSO availability * Rename get_sso_institutions to get_non_hidden_institutions * Enhance institution population script with test institution generation and SSO state handling * Refactor institution update logic to handle non-existent institutions and improve logout URL generation * Implement validation for SSO availability in InstitutionForm * fix institution form unit tests * Refactor SSO availability validation in InstitutionForm and override post method in InstitutionChangeForm for custom behavior * Apply suggestion from @cslzchen * Enable/disable "Copy SSO URL" button based on CAS login URL availability * Improve SSO availability validation messages in InstitutionForm and enhance error handling in InstitutionChangeForm * Update SSO availability validation error message in InstitutionForm test * Disable "Copy SSO URL" button if institution is deactivated * Refactor SSO availability validation in InstitutionForm to ensure correct settings based on delegation protocol and institution status * Add merge migration * Rework auth views/routes/redirects * Fix incorrect handling of invalid session/cookie * Add local mode and update web_url_for to support angular domain * Update auth views to use updated web_url_for * Update auth views tests * Add login url builder and update logout url builder * Fix some tests * Update institution's CAS login url in admin * More auth view update and more tests fix * Fix the last couple of failures * Fix goodbye route --------- Co-authored-by: Ihor Sokhan <isokhan@exoft.net> Co-authored-by: Vlad0n20 <vlad.onischuk1234@gmail.com> Co-authored-by: Longze Chen <cslzchen@gmail.com>
Collaborator
Author
|
Diff looks good 🐧 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reference PR for release 26.10.0