fix: consistent shtrove record identifiers#11761
Open
aaxelb wants to merge 1 commit into
Open
Conversation
adlius
approved these changes
Jun 3, 2026
Collaborator
|
There are some test failures. |
when sending cedar records to shtrove as supplementary records about an item, use that item's osfid in the record_identifier instead of a database id, so the records are more clearly associated in shtrove admin
aaxelb
force-pushed
the
fix/consistent-shtrove-supplement-ids
branch
from
e212fdb to
3048525
Compare
Collaborator
Author
|
@adlius oops sorry, shoulda waited -- passing now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when sending cedar records to shtrove as supplementary records about an item, use that item's osfid in the record_identifier instead of a database id, so the records are more clearly associated in shtrove admin
Ticket
Purpose
Changes
Side Effects
QE Notes
CE Notes
Documentation