Skip to content

[ENG-11304] Filter notifications to only include unsent notifications in email tasks #11765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cslzchen merged 1 commit into from
Jun 4, 2026
+2 −2
Merged

[ENG-11304] Filter notifications to only include unsent notifications in email tasks #11765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions notifications/tasks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ def send_user_email_task(self, user_id, notification_ids, **kwargs):
return

try:
notifications_qs = Notification.objects.filter(id__in=notification_ids)
notifications_qs = Notification.objects.filter(id__in=notification_ids, sent__isnull=True)
rendered_notifications, failed_notifications = safe_render_notification(notifications_qs, email_task)
notifications_qs = notifications_qs.exclude(id__in=failed_notifications)

Expand Down Expand Up @@ -168,7 +168,7 @@ def send_moderator_email_task(self, user_id, notification_ids, provider_content_
return

try:
notifications_qs = Notification.objects.filter(id__in=notification_ids)
notifications_qs = Notification.objects.filter(id__in=notification_ids, sent__isnull=True)
rendered_notifications, failed_notifications = safe_render_notification(notifications_qs, email_task)
notifications_qs = notifications_qs.exclude(id__in=failed_notifications)

Expand Down