Feature/corpus settings#2103
Merged
Merged
Conversation
…y-settings-formats Feature/unify settings formats
…ieslab/I-analyzer into feature/corpus-settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Finally got around to implementing this. Changes the corpus settings format according to #2099
The new format can exist side by side with the old one (you could even use both formats in the same corpus) but it should fully replace it.
For some corpora, I've changed the definition so they support the new format as well as the old one (but there is a log warning if you use the old setting). This adds a significant expansion of code, which is temporary. For example, this was the ParliamentCanada definition:
Now changed to:
After deployment, this can be changed to:
Changes to Django settings
This adds the
CORPUS_SETTINGSDjango setting. No immediate change is required, but the log will show a warning if a corpus can be switched toCORPUS_SETTINGSand this has not been done in the environment.