Feature/unify settings formats#2114
Merged
JeltevanBoheemen merged 4 commits intoJul 15, 2026
Merged
Conversation
lukavdplas
requested changes
Jul 15, 2026
lukavdplas
left a comment
lukavdplas
left a comment
Contributor
There was a problem hiding this comment.
Nice! A few minor changes required.
Comment on lines
-19
to
23
| TIMES_DATA = os.path.join(BASE_DIR, 'addcorpus', 'python_corpora', 'tests') | ||
| TIMES_ES_INDEX = 'test-times' | ||
|
|
||
| UBLAD_DATA = '' # necessary to make ublad test not fail | ||
| CORPUS_SETTINGS = { | ||
| "times": { | ||
| "data_directory": os.path.join(BASE_DIR, 'addcorpus', 'python_corpora', 'tests'), | ||
| "es_index": "test-times", | ||
| }, | ||
| "ublad": { | ||
| "data_directory": "" | ||
| } | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
The ublad setting isn't needed anymore. This would have been required to import the module in a test:
The ublad module would raise an AttributeError on import if settings.UBLAD_DATA does not exist. But now you can just import the module, yay!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts the
get_deprecated_settinghelper, and adjusts all corpora using it to the new settings format.Also removes (almost) all old-style settings (
getatttr(settings.SOME_SETTING, <default>). Exceptions:This was a combination of manual moving of settings, and using an LLM-based helper. So a quick sanity check would be much appreciated.
Deployment
Branches updated for:
Sanity checks also appreciated