Skip to content

Release 3.3#125

Merged
miggol merged 34 commits into
masterfrom
develop
Apr 21, 2026
Merged

Release 3.3#125
miggol merged 34 commits into
masterfrom
develop

Conversation

@miggol
Copy link
Copy Markdown
Contributor

@miggol miggol commented Jul 1, 2025

This is a compatibility release aiming to support Django 5.1. It also contains some bugfixes.

To do:

  • Merge open PRs into develop
  • Evaluate if Django 5.2 support can be easily included
  • Update CI test workflows
  • Write release notes
  • Update version in pyproject.toml

Leaving this as a draft until the above is addressed. Ready for review

Draft release notes

Details Holdover release supporting Django 5.1, while final fixes are being made to support 5.2. What's Changed
fix: fixed an XSS exploit in transformat by @tymees in https://github.com/CentreForDigitalHumanities/django-shared-core/pull/111
Avoid deprecated escaping for Python 3.12 by @miggol in https://github.com/CentreForDigitalHumanities/django-shared-core/pull/115
prevent assigning empty for="" attributes to s by @bbonf in https://github.com/CentreForDigitalHumanities/django-shared-core/pull/106
Fix bootstrap built by @tymees in https://github.com/CentreForDigitalHumanities/django-shared-core/pull/124
Avoid logging error on every ApiError by @bbonf in https://github.com/CentreForDigitalHumanities/django-shared-core/pull/123
Fixes required for Django 5.1 support by @miggol in https://github.com/CentreForDigitalHumanities/django-shared-core/pull/121
Fix for vbuild not working on python 3.13 by @bbonf in https://github.com/CentreForDigitalHumanities/django-shared-core/pull/131
Minor SAML/Django-CSP fixes by @tymees in https://github.com/CentreForDigitalHumanities/django-shared-core/pull/129
Quick fix: unfederate django.contrib. auth by @miggol in https://github.com/CentreForDigitalHumanities/django-shared-core/pull/128
Fix github workflows by @miggol in https://github.com/CentreForDigitalHumanities/django-shared-core/pull/126
v3.3 - Update versions and requirements by @miggol in https://github.com/CentreForDigitalHumanities/django-shared-core/pull/135

New Contributors

@miggol made their first contribution in https://github.com/CentreForDigitalHumanities/django-shared-core/pull/115

Full Changelog: v3.2.0...v3.3.0

bbonf and others added 14 commits August 5, 2024 13:35
Previously, the code for detecting 'safe' strings was completely broken to the point of 'how did I write this'. This implements the intended behaviour correctly
…rability-transformat

fix: fixed an XSS exploit in transformat
This provides compatiblity with Django 5.1. The hidden attribute is available from Django 4.0 and up with the same semantics as `is_hidden`. (In fact, it used to call `is_hidden`).
…-python-312

Avoid deprecated escaping for Python 3.12
…el-for

prevent assigning empty for="" attributes to <label>s
@tymees
Copy link
Copy Markdown
Member

tymees commented Jul 1, 2025

One of the issues (the one that crashes tests) is the CSP + SAML integration problem; if you want, I'm willing to fix that up. (Seeing as I still do SAML support)

@miggol
Copy link
Copy Markdown
Contributor Author

miggol commented Jul 9, 2025

One of the issues (the one that crashes tests) is the CSP + SAML integration problem; if you want, I'm willing to fix that up. (Seeing as I still do SAML support)

That would be awesome, Ty!

@miggol
Copy link
Copy Markdown
Contributor Author

miggol commented Jul 18, 2025

There is a single small issue (#127) blocking 5.2 support, at least as far as the Django tests are concerned. I'm calling that DSC 3.3 will support 5.1 and we can support 5.2 pretty shortly afterwards in 3.4.

@miggol miggol marked this pull request as ready for review March 26, 2026 14:44
@miggol miggol requested a review from tymees March 26, 2026 14:44
@miggol
Copy link
Copy Markdown
Contributor Author

miggol commented Mar 26, 2026

Ready for review

@miggol miggol changed the title [Draft] Release 3.3 Release 3.3 Mar 27, 2026
Copy link
Copy Markdown
Member

@tymees tymees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@miggol miggol merged commit 02a1535 into master Apr 21, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants