Skip to content

Commit 0d8becf

Browse files
Use logger instead of print
1 parent a6c1eaf commit 0d8becf

1 file changed

Lines changed: 15 additions & 9 deletions

File tree

backend/problem/services.py

Lines changed: 15 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
import json
2+
3+
from langpro_annotator.logger import logger
24
from .models import Problem
35
from .types import FracasProblem, SickProblem
46

@@ -9,11 +11,11 @@ def get_sick_problems() -> list[SickProblem]:
911
and converts them into SickProblem instances.
1012
"""
1113
sick_problems: list[SickProblem] = []
12-
problem_objects = Problem.objects.filter(type=Problem.ProblemType.SICK)
14+
sick_objects = Problem.objects.filter(type=Problem.ProblemType.SICK)
1315

14-
for problem_obj in problem_objects:
16+
for sick_obj in sick_objects:
1517
try:
16-
problem_data = json.loads(problem_obj.content)
18+
problem_data = json.loads(sick_obj.content)
1719
problem = SickProblem(
1820
pair_id=problem_data["pair_ID"],
1921
sentence_one=problem_data["sentence_A"],
@@ -23,13 +25,15 @@ def get_sick_problems() -> list[SickProblem]:
2325
)
2426
sick_problems.append(problem)
2527
except json.JSONDecodeError:
26-
print(
27-
f"Warning: Could not parse JSON content for Problem ID {problem_obj.id}"
28+
logger.warning(
29+
f"Warning: Could not parse JSON content for Problem ID {sick_obj.id}"
2830
)
31+
continue
2932
except TypeError as e:
30-
print(
31-
f"Warning: Could not create SickProblem for Problem ID {problem_obj.id}: {e}"
33+
logger.warning(
34+
f"Warning: Could not create SickProblem for Problem ID {sick_obj.id}: {e}"
3235
)
36+
continue
3337

3438
return sick_problems
3539

@@ -59,12 +63,14 @@ def get_fracas_problems() -> list[FracasProblem]:
5963
)
6064
fracas_problems.append(problem)
6165
except json.JSONDecodeError:
62-
print(
66+
logger.warning(
6367
f"Warning: Could not parse JSON content for Problem ID {problem_obj.id}"
6468
)
69+
continue
6570
except TypeError as e:
66-
print(
71+
logger.warning(
6772
f"Warning: Could not create FracasProblem for Problem ID {problem_obj.id}: {e}"
6873
)
74+
continue
6975

7076
return fracas_problems

0 commit comments

Comments
 (0)