Skip to content

Commit 1a5d7a8

Browse files
Apply suggestions from code review in #79
Co-authored-by: Xander Vertegaal <73882506+XanderVertegaal@users.noreply.github.com>
1 parent a5d3aca commit 1a5d7a8

2 files changed

Lines changed: 3 additions & 4 deletions

File tree

frontend/src/app/annotate/annotation-menu/annotation-menu.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@
3333
<span i18n>Proof / Contradiction</span>
3434
</button>
3535
<ng-template ngbNavContent>
36-
<section style="overflow-x: scroll;">
36+
<section class="overflow-x-scroll">
3737
@if (proofs) {
3838
<la-tableau-svg [tree]="proofs.contradiction"></la-tableau-svg>
3939
}

frontend/src/app/services/parse.service.ts

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,9 +109,8 @@ export function nltk2tableau(nltk: NLTKTree): ProofTree {
109109
// The algorithm is written such that the order in which we process
110110
// child nodes does not matter, so we can simply pop thunks off the back
111111
// of the todo list. tsc is apparently unable to infer that `todo` is
112-
// guaranteed to be nonempty on the next line, hence the silencing
113-
// comment.
114-
// @ts-ignore
112+
// guaranteed to be nonempty on the next line; hence
113+
// the type assertion.
115114
const task = todo.pop() as ProofConversionThunk;
116115
// Processing a thunk might produce zero or more new thunks, depending
117116
// on the number of children of the processed node.

0 commit comments

Comments
 (0)