Make NLTK -> Tableau conversion more robust against unexpected input

jgonggrijp · jgonggrijp · commit 73ca08dcb81d · 2026-03-19T18:02:58.000+01:00
diff --git a/frontend/src/app/services/parse.service.ts b/frontend/src/app/services/parse.service.ts
@@ -72,7 +72,7 @@ function nltkNode2tableauNode(nltk: any, tree: any) {
     const lines = nltk.node.split('\n');
     if (lines[0] === 'Closed') {
         node.rule = lines[1];
-    } else if (lines[0] !== 'Model') {
+    } else if (lines.length >= 3) {
         const sign = lines.pop();
         node.sign = (sign === 'True');
         const tagLine = lines.shift().split(':');
@@ -93,6 +93,8 @@ function nltkNode2tableauNode(nltk: any, tree: any) {
             }
         }
         if (lines.length) node.head = lines[0];
+    } else if (lines[0] !== 'Model') {
+        node.head = nltk.node;
     }
     if (!nltk.children || !nltk.children.length) {
         node.end = true;

Original file line number	Diff line number	Diff line change
`@@ -72,7 +72,7 @@ function nltkNode2tableauNode(nltk: any, tree: any) {`
`72`	`72`	`const lines = nltk.node.split('\n');`
`73`	`73`	`if (lines[0] === 'Closed') {`
`74`	`74`	`node.rule = lines[1];`
`75`		`- } else if (lines[0] !== 'Model') {`
	`75`	`+ } else if (lines.length >= 3) {`
`76`	`76`	`const sign = lines.pop();`
`77`	`77`	`node.sign = (sign === 'True');`
`78`	`78`	`const tagLine = lines.shift().split(':');`
`@@ -93,6 +93,8 @@ function nltkNode2tableauNode(nltk: any, tree: any) {`
`93`	`93`	`}`
`94`	`94`	`}`
`95`	`95`	`if (lines.length) node.head = lines[0];`
	`96`	`+ } else if (lines[0] !== 'Model') {`
	`97`	`+ node.head = nltk.node;`
`96`	`98`	`}`
`97`	`99`	`if (!nltk.children \|\| !nltk.children.length) {`
`98`	`100`	`node.end = true;`