Make NLTK -> Tableau conversion more robust against unexpected input

jgonggrijp · jgonggrijp · commit 7c7abdbffb97 · 2026-03-17T03:13:51.000+01:00
diff --git a/frontend/src/app/services/parse.service.ts b/frontend/src/app/services/parse.service.ts
@@ -57,7 +57,7 @@ function nltkNode2tableauNode(nltk: any, tree: any) {
     const lines = nltk.node.split('\n');
     if (lines[0] === 'Closed') {
         node.rule = lines[1];
-    } else if (lines[0] !== 'Model') {
+    } else if (lines.length >= 3) {
         const sign = lines.pop();
         node.sign = (sign === 'True');
         const tagLine = lines.shift().split(':');
@@ -78,6 +78,8 @@ function nltkNode2tableauNode(nltk: any, tree: any) {
             }
         }
         if (lines.length) node.head = lines[0];
+    } else if (lines[0] !== 'Model') {
+        node.head = nltk.node;
     }
     if (!nltk.children || !nltk.children.length) {
         node.end = true;

Original file line number	Diff line number	Diff line change
`@@ -57,7 +57,7 @@ function nltkNode2tableauNode(nltk: any, tree: any) {`
`57`	`57`	`const lines = nltk.node.split('\n');`
`58`	`58`	`if (lines[0] === 'Closed') {`
`59`	`59`	`node.rule = lines[1];`
`60`		`- } else if (lines[0] !== 'Model') {`
	`60`	`+ } else if (lines.length >= 3) {`
`61`	`61`	`const sign = lines.pop();`
`62`	`62`	`node.sign = (sign === 'True');`
`63`	`63`	`const tagLine = lines.shift().split(':');`
`@@ -78,6 +78,8 @@ function nltkNode2tableauNode(nltk: any, tree: any) {`
`78`	`78`	`}`
`79`	`79`	`}`
`80`	`80`	`if (lines.length) node.head = lines[0];`
	`81`	`+ } else if (lines[0] !== 'Model') {`
	`82`	`+ node.head = nltk.node;`
`81`	`83`	`}`
`82`	`84`	`if (!nltk.children \|\| !nltk.children.length) {`
`83`	`85`	`node.end = true;`